From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4905 invoked by alias); 20 Feb 2020 17:59:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4896 invoked by uid 89); 20 Feb 2020 17:59:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.67.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Feb 2020 17:59:56 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway20.websitewelcome.com (Postfix) with ESMTP id A965C400CC546 for ; Thu, 20 Feb 2020 10:45:53 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4q79j1mhqRP4z4q79jRncV; Thu, 20 Feb 2020 11:59:55 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=u5u0Pzqyec8WvdaxUix3YEPbsZnayalMTC8XDNMe5Jc=; b=MK8abD3tnIxn6/+IAKf/Zfv/4V eptz7KH4R+H5VeAdGX6Ii51OwfU9dsYI/9J9ALkVnKgDoEBWqgfFZe5Wj/XJQ08Zo2Rj5H0uyjIib /wOZWxd5pTXkaEUdttWwO3Fzp; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:56692 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j4q78-001rku-PR; Thu, 20 Feb 2020 10:59:54 -0700 From: Tom Tromey To: Aaron Merey Cc: Simon Marchi , gdb-patches@sourceware.org, Tom Tromey , Christian Biesinger Subject: Re: [PATCH v3] Add debuginfod support to GDB References: Date: Thu, 20 Feb 2020 17:59:00 -0000 In-Reply-To: (Aaron Merey's message of "Mon, 10 Feb 2020 18:51:30 -0500") Message-ID: <87ftf5jg12.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00833.txt.bz2 >>>>> "Aaron" == Aaron Merey writes: Aaron> Thanks for the feedback, I've updated the patch with your suggestions Aaron> (attached) and I've included some additional comments below. We've been discussing the patch on irc a bit, and while looking at it I found a nit. Aaron> + if (IS_DIR_SEPARATOR (s->filename[0])) This should probably use IS_ABSOLUTE_PATH. You can just make this change locally, you don't need to send a new version of the patch. Tom