Re: [PATCH 1/2] Use bool in ada_add_all_symbols

[Tom Tromey <tromey@adacore.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

>> -   FULL_SEARCH is non-zero, enclosing scope and in global scopes,
>> +   FULL_SEARCH is true, enclosing scope and in global scopes,
>> returning the number of matches.  Add these to RESULT.
>> 
>> -   When FULL_SEARCH is non-zero, any non-function/non-enumeral
>> +   When FULL_SEARCH is false, any non-function/non-enumeral

Andrew> I found the description in this comment for what FULL_SEARCH actually
Andrew> does really confusing.

Andrew> I noticed that you replaced non-zero with false not true, which is an
Andrew> inversion of the logic.  I thought I'd just read the comment and check
Andrew> the code, then I'd know if this was a fix or not.  But I cannot tell
Andrew> from the comment what the code is supposed to do, so I'm stuck.

Andrew> All I know is that the code didn't change, but the comment has flipped
Andrew> logic, and the commit message doesn't call this out as a fix, so I
Andrew> wanted to check with you.

Yeah, that was just a mistake in the comment update.

>> -   When full_search is non-zero, any non-function/non-enumeral
>> +   When full_search is false, any non-function/non-enumeral

Andrew> While here it would be good to capitalise FULL_SEARCH.  Also non-zero
Andrew> became false here instead of true, as with ada_add_all_symbols, is this
Andrew> intentional?

I fixed this too, it was not intentional.

Tom