Re: [PATCH 2/2] Use bool in map_matching_symbols

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tromey@adacore.com> writes:

> This changes ada-lang.c:map_matching_symbols to take a bool parameter,
> then fixes up the callers.
> ---
>  gdb/ada-lang.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
> index afdd59965fd..47433ccf6b7 100644
> --- a/gdb/ada-lang.c
> +++ b/gdb/ada-lang.c
> @@ -5551,7 +5551,7 @@ static void
>  map_matching_symbols (struct objfile *objfile,
>  		      const lookup_name_info &lookup_name,
>  		      domain_search_flags domain,
> -		      int global,
> +		      bool global,
>  		      match_data &data)
>  {
>    data.objfile = objfile;
> @@ -5579,7 +5579,7 @@ map_matching_symbols (struct objfile *objfile,
>  static void
>  add_nonlocal_symbols (std::vector<struct block_symbol> &result,
>  		      const lookup_name_info &lookup_name,
> -		      domain_search_flags domain, int global)
> +		      domain_search_flags domain, bool global)

The comment on this function needs updating, it still says non-zero when
discussing GLOBAL.

Otherwise,

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew