From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id caZ4Ktrg/WlulyMAWB0awg (envelope-from ) for ; Fri, 08 May 2026 09:10:50 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CgePGtrN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A9C391E0BA; Fri, 08 May 2026 09:10:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 473821E067 for ; Fri, 08 May 2026 09:10:50 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9B9884BA5439 for ; Fri, 8 May 2026 13:10:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9B9884BA5439 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CgePGtrN Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 7016F4BA5439 for ; Fri, 8 May 2026 13:10:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7016F4BA5439 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7016F4BA5439 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778245824; cv=none; b=ZjGr1i1Wg4J8zT8vrfPP7KPoJM3Sd8GRxGbL7RxC7aaXtQr83t9pmGfAN0cEDDN07zILbBpFL/HFyelcDoLZ127dvMmJUSUYaIGUMUEXPb+N3bK7/ctFEn8uGhDWk/6OKNowKOVFbecM84bMao9bcumivwUg7sxJ5htweWkR3cY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778245824; c=relaxed/simple; bh=lXjJGT8Zc8buO+LXvZoz8GwifFPccARomK5h/RftVNI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=q/msWaHoL6QwoVNeZfEAtKv/bVNOq/6rlQNBbDqdVfqd9JkpgdZu0oHSNn3MMSwdAkQ1qtMaaMueTncIWSZXXPQ4LrDz135EIfijnmL1XPoTWGh479y2xmnnDiHDa/qEZ3LqYvqDt4jXCZaNcZRNCJB7VDxHY4hy4ApdheqwJfY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CgePGtrN DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7016F4BA5439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778245824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jKQBmNzRLQ79ZETLxshc2ViVGUU0swq0tyyvtneVdgY=; b=CgePGtrNI/Lk43ACwWp/uhow5szc3iSgBSVECeeoFHiHF3HCUstpOudKN2QfrQEFU2GfLN sWGK5X9cTCH9rMADaK0Tvei0nL+MYK2F2WRPBWPrdv+0oOi4dh83EeN25JPZU+xRl29YdG uvYsqwPxAXaPn0kTVw1c5AbDGYrgyLc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-ovPIITr3PiK6xIW3KVj-XQ-1; Fri, 08 May 2026 09:10:22 -0400 X-MC-Unique: ovPIITr3PiK6xIW3KVj-XQ-1 X-Mimecast-MFC-AGG-ID: ovPIITr3PiK6xIW3KVj-XQ_1778245822 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43fe791a398so1684557f8f.0 for ; Fri, 08 May 2026 06:10:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778245821; x=1778850621; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jKQBmNzRLQ79ZETLxshc2ViVGUU0swq0tyyvtneVdgY=; b=Cv6ERAZ2msxOZgU95bpR/taSoLA+hTFzg2PVu1S0uDUjXHF6Ty08dvw7xrk+EDO6qL JdHA9nW5Nc1sJTqwYJhECINY5zTq7gbj05r0XDTZKOqRDitwEb+4O/NH8XBWXjv+JIGJ 8mFC2HkltuViiRxc+Fjz4iB+pnq/M0Utva9dZi2idy4wEDk043fh/SP3OmUvbZ0DkS5D dGQEkpjqnCRAz6VBDszzPEaDNP1XPZQv8dmymcA/pTqPjQyRD3kIP7nowk8S7kNplvO7 y9Vnb/65X6TMURiZubGbEgZWC02Xr5U1XzjnCvvqqkHJEhyXTlcJi6kZYQtn94hKHhTx BG1w== X-Forwarded-Encrypted: i=1; AFNElJ9PQD/6dRy6KdslBMq1BvnFPHBGNQaszgJBWyeW5zljfym83VZH/6SNrfgvjS2zHE4QmK5EFTKXAxrBsw==@sourceware.org X-Gm-Message-State: AOJu0Yxf0ME4VryFDUEvJxYzvxB5cRP2vgqFgcuEeNdDnTUMDOqR3sig CwtG4VFEYC0gHEEHssqO9f8g8jQiMx+K7BYvYNQLE4Xy0YMUjEfnfb9+gMhP6fW+zQhFgkToZtD 3DIMcBt2onG2C9UWaCrW3YOmu3SaOeCxhE6MZlv/T4v07A3lBZ29nkb8mluqPOpK7UifwzjY= X-Gm-Gg: AeBDietU2brS5cFS7HS98+Z3SqOhxYVFzOdjQgM++q7a9R1gHxXY0pC17lGlXo5qwvc DUk0l8RTuySrTL/TX8aEQj53qNB5NlwPHBCupR6LM+3AYxo53uUeXJs/kHBb4i9tE+ntPJX5EKe xLRyTRCY1RkZ1HpI1qmJrZT7Pmx4+rCLvIyaPvvsV3O2+HZ1kZhVLnC9GtlFows96qxyG/CBOXd V7zOqte2UsJE87Gxb0CWPZwIZ8fRPpK8btvhIN8w988WpKRuRxJa7MI85HIF+mOhXe2m1KrPplS eZW4LrTyn/YOJD+jr+3xKaGJo9/TcPlngmL7mxYoXeaQ34R0As8Xr+J8EMGjigJUKR3E5eXvCkF lDUAAVoHicMhyC36J X-Received: by 2002:a05:600c:470a:b0:488:a639:b772 with SMTP id 5b1f17b1804b1-48e51e15485mr199174035e9.7.1778245821234; Fri, 08 May 2026 06:10:21 -0700 (PDT) X-Received: by 2002:a05:600c:470a:b0:488:a639:b772 with SMTP id 5b1f17b1804b1-48e51e15485mr199173465e9.7.1778245820689; Fri, 08 May 2026 06:10:20 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e68f43d1fsm42534835e9.10.2026.05.08.06.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 06:10:20 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH 2/2] Use bool in map_matching_symbols In-Reply-To: <20260424-ada-bool-again-v1-2-cb63db324fff@adacore.com> References: <20260424-ada-bool-again-v1-0-cb63db324fff@adacore.com> <20260424-ada-bool-again-v1-2-cb63db324fff@adacore.com> Date: Fri, 08 May 2026 14:10:19 +0100 Message-ID: <87a4uadp38.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qVSws6KFte4byYj96Mrg-6paN0ac8AOF4RH3_JXmhT8_1778245822 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: > This changes ada-lang.c:map_matching_symbols to take a bool parameter, > then fixes up the callers. > --- > gdb/ada-lang.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c > index afdd59965fd..47433ccf6b7 100644 > --- a/gdb/ada-lang.c > +++ b/gdb/ada-lang.c > @@ -5551,7 +5551,7 @@ static void > map_matching_symbols (struct objfile *objfile, > const lookup_name_info &lookup_name, > domain_search_flags domain, > - int global, > + bool global, > match_data &data) > { > data.objfile = objfile; > @@ -5579,7 +5579,7 @@ map_matching_symbols (struct objfile *objfile, > static void > add_nonlocal_symbols (std::vector &result, > const lookup_name_info &lookup_name, > - domain_search_flags domain, int global) > + domain_search_flags domain, bool global) The comment on this function needs updating, it still says non-zero when discussing GLOBAL. Otherwise, Approved-By: Andrew Burgess Thanks, Andrew