From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id T9OiFuzq/WlmyCMAWB0awg (envelope-from ) for ; Fri, 08 May 2026 09:53:48 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=i8oOb2Gt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4B0691E067; Fri, 08 May 2026 09:53:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9E6131E067 for ; Fri, 08 May 2026 09:53:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2849E4BA2E10 for ; Fri, 8 May 2026 13:53:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2849E4BA2E10 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=i8oOb2Gt Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) by sourceware.org (Postfix) with ESMTPS id B112D4BA2E1E for ; Fri, 8 May 2026 13:53:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B112D4BA2E1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B112D4BA2E1E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778248395; cv=none; b=bwhFfGShNqUOpBmvl3YkNmJKEndQgISkWavPbnvubCoowQuXpNy9sm7WUrMsqXmjF1WcZprtkXmg+Yoknn5Ys7pRoScLA9MKbU0ZSttyMHVF0nEC2RyTaECMjM72dGsEv0/VFn2T/kMPG060eSoKpEvtwz/HS9Rl7Wa218jQw18= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778248395; c=relaxed/simple; bh=qcalc0b+s2vKJ0WAr20BciZI/nk9HCbMddA+GavTUaE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GrtUkYfZr435B4NNtgKnYjLitS4//nOiApIhS/SSFHNyI8CApmwP438Gb2xkSEB+p69xBXEEeFTIg/sxvPIRttFU11k2XeUWmGbbnOh58EI+0l/7aJeErTivcaNv3OFfq7+5+AYh1mkxd4xWtc8uoMWb5asETgJ8IdMJzeoJV9E= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=i8oOb2Gt DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B112D4BA2E1E Received: by mail-oo1-xc2c.google.com with SMTP id 006d021491bc7-688a8e5fe5eso1084870eaf.1 for ; Fri, 08 May 2026 06:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1778248395; x=1778853195; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=aw8Uk4g75ia33OyLzhvSFq8/waQoHcisWSayWZNX9us=; b=i8oOb2Gtp2dPlPT96xcoevRO1/fWrLjEOEpNLoECRVmJHguLRSdUcfSi98CZa07XLC AbstfgaepPunpvwBliUYvh6Cmly2CbHwXIKLYAqhG9nPw/ITNEGXiwuOUy1zuLSfER7b CAvBqNvkyQhDRuYjDflWzHgmJfPMbXBo2427zfxzcOhkCmFDpUw6QGEwqSAP08MDN7o2 LmN8t3Rcb8iMyZ59X41sz8YwN9Ofpoa4ZlrCIXbWiLscMXHz0hWmaQsTbUSSvqiiEC4+ Rp/kYr7TAZUlH5/PfouFWkyhJYHZwj+faHwfmcIZONIMKwIIhNXC2yqQq8yL7A6s6WxZ 63Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778248395; x=1778853195; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=aw8Uk4g75ia33OyLzhvSFq8/waQoHcisWSayWZNX9us=; b=Fw7eQoUfSa7xKWnhNhIq2Q6yzE40QcS+gRxS0GTF6afFiTFg9kHyAMAKMIeTJucvdP ymVVE6GdZ2sDLv7n3X6ydLa4QVaK2TD0/SuB9JftbMSOmirN9Io95VqA1DiFr56qFsFC 9aZ5+zUnF2VYZotXMRGuu0m3NcCdDmssMMBEaInUNu7UMiDxi+PzJ98FY+Zn2JJyy+HR SqafVG+jlYjacwpMnN99Xip4VfevNVeuB4bhq37UaQTYbqiqYJjMKSZIimXJg8tdsMV4 URPN3HDBIWIcSWku2qnBwWcfJmm9o3XcqK+5kp4Ov69INyP20Qaf0lhzzaF3oHjDpAS3 pBrA== X-Forwarded-Encrypted: i=1; AFNElJ9OWdPT6glL8OxY0dNokUQCVJYMFeEe9jlrs0P4fXazhke/hDWRZboWnnLuajEhGjGzhH6xS4h1dSBIoA==@sourceware.org X-Gm-Message-State: AOJu0YwAP6kU1Hvmhx5fMYGPpC99tfyBXt5a2k1zXkJYkpUdjkMRdq5J p6YhZI3b5yRSKhLkbDlIr302/TPLa2589Z9fvyRdiaYgAnn0yEvW/bh01X2o05k60g== X-Gm-Gg: AeBDievldZXmNUNSy2e6FoYzz2MxB8L/2cQCdRuvVv7N9T8B7/0xhdR/KArgDbgaSR3 Mh6FLB7g5sGrNSu9f4qAJRKAzl0sK+t3im7AyaPR1QazQR7F3BpPp5vAU0sutFzID4/nEOVvJd2 Z5/DWAVE3okol1KqZNZ/UovFFbgTzMDymPtLofmfOxCjTAp46MbvwPiE4mCNmcBCMzrhIvsRgvv I7gjz1zHKH1bOQ/uDVESOGPbOsgPB9ZcDTv7Ov0F2TTkgK5bnwMoyuS4B6Xt53DTa0ZoD1XL/cH rqSHu0+66/+WXHySYe+2t8Bbu5n6ga/AHttbwlM4XKWkLy5woo7Gp38r0vXzuc1CduRwqUMBR5A Kpq/hSX8UKVvgmqWc/dZJmImON44dVXPW7fFN0L7eh/UfirOFd9lOh5FsqXFs+IaynUmA1qZOPd v0kfOHaJlb+nvNLyDoJNZUG8X7pWPqoLbX9okiN6vp88o= X-Received: by 2002:a05:6820:2224:b0:695:3a00:855c with SMTP id 006d021491bc7-69998d0e031mr7480548eaf.39.1778248394963; Fri, 08 May 2026 06:53:14 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43556bbebe6sm1785496fac.0.2026.05.08.06.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 06:53:14 -0700 (PDT) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Use bool in ada_add_all_symbols In-Reply-To: <87cxz6dq09.fsf@redhat.com> (Andrew Burgess's message of "Fri, 08 May 2026 13:50:30 +0100") References: <20260424-ada-bool-again-v1-0-cb63db324fff@adacore.com> <20260424-ada-bool-again-v1-1-cb63db324fff@adacore.com> <87cxz6dq09.fsf@redhat.com> X-Attribution: Tom Date: Fri, 08 May 2026 07:53:13 -0600 Message-ID: <87fr42nh2u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: >> - FULL_SEARCH is non-zero, enclosing scope and in global scopes, >> + FULL_SEARCH is true, enclosing scope and in global scopes, >> returning the number of matches. Add these to RESULT. >> >> - When FULL_SEARCH is non-zero, any non-function/non-enumeral >> + When FULL_SEARCH is false, any non-function/non-enumeral Andrew> I found the description in this comment for what FULL_SEARCH actually Andrew> does really confusing. Andrew> I noticed that you replaced non-zero with false not true, which is an Andrew> inversion of the logic. I thought I'd just read the comment and check Andrew> the code, then I'd know if this was a fix or not. But I cannot tell Andrew> from the comment what the code is supposed to do, so I'm stuck. Andrew> All I know is that the code didn't change, but the comment has flipped Andrew> logic, and the commit message doesn't call this out as a fix, so I Andrew> wanted to check with you. Yeah, that was just a mistake in the comment update. >> - When full_search is non-zero, any non-function/non-enumeral >> + When full_search is false, any non-function/non-enumeral Andrew> While here it would be good to capitalise FULL_SEARCH. Also non-zero Andrew> became false here instead of true, as with ada_add_all_symbols, is this Andrew> intentional? I fixed this too, it was not intentional. Tom