Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/symtab] Fix symbol loading performance regression
Date: Wed, 29 May 2019 18:36:00 -0000	[thread overview]
Message-ID: <87ef4hxg4j.fsf@tromey.com> (raw)
In-Reply-To: <20190513092700.GA9733@delia> (Tom de Vries's message of "Mon, 13	May 2019 11:27:02 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> 2019-05-11  Tom de Vries  <tdevries@suse.de>

Tom> 	PR symtab/24545
Tom> 	* symtab.c (struct demangled_name_entry): Add language field.
Tom> 	(symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
Tom> 	static minimal symbol".  Set and use language field.

Thanks for doing this.

Tom> +      char *demangled_name = symbol_find_demangled_name (gsymbol,
Tom> +							 linkage_name_copy);

I think it would be better to do

    gdb::unique_xmalloc_ptr<char> demangled_name (...);

and then adjust the code to use ".get ()" as needed.

This is ok with that change.

Tom


  parent reply	other threads:[~2019-05-29 18:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13  9:27 Tom de Vries
2019-05-27  6:46 ` [PING][PATCH][gdb/symtab] " Tom de Vries
2019-05-29 18:36 ` Tom Tromey [this message]
2019-07-18 14:23   ` [8.3 backport][gdb/symtab] " Tom de Vries
2019-07-19 17:02     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef4hxg4j.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox