From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: [8.3 backport][gdb/symtab] Fix symbol loading performance regression
Date: Thu, 18 Jul 2019 14:23:00 -0000 [thread overview]
Message-ID: <28238d42-4db2-8733-67fb-9072526242b3@suse.de> (raw)
In-Reply-To: <87ef4hxg4j.fsf@tromey.com>
On 29-05-19 20:36, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> 2019-05-11 Tom de Vries <tdevries@suse.de>
>
> Tom> PR symtab/24545
> Tom> * symtab.c (struct demangled_name_entry): Add language field.
> Tom> (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
> Tom> static minimal symbol". Set and use language field.
>
> Thanks for doing this.
>
> Tom> + char *demangled_name = symbol_find_demangled_name (gsymbol,
> Tom> + linkage_name_copy);
>
> I think it would be better to do
>
> gdb::unique_xmalloc_ptr<char> demangled_name (...);
>
> and then adjust the code to use ".get ()" as needed.
>
> This is ok with that change.
Is this also ok for 8.3.1? The patch applies cleanly.
Thanks,
- Tom
next prev parent reply other threads:[~2019-07-18 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 9:27 [PATCH][gdb/symtab] " Tom de Vries
2019-05-27 6:46 ` [PING][PATCH][gdb/symtab] " Tom de Vries
2019-05-29 18:36 ` [PATCH][gdb/symtab] " Tom Tromey
2019-07-18 14:23 ` Tom de Vries [this message]
2019-07-19 17:02 ` [8.3 backport][gdb/symtab] " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28238d42-4db2-8733-67fb-9072526242b3@suse.de \
--to=tdevries@suse.de \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox