From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58220 invoked by alias); 18 Jul 2019 14:23:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58211 invoked by uid 89); 18 Jul 2019 14:23:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:822 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Jul 2019 14:23:55 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 32572AC0C; Thu, 18 Jul 2019 14:23:53 +0000 (UTC) Subject: [8.3 backport][gdb/symtab] Fix symbol loading performance regression To: Tom Tromey Cc: gdb-patches@sourceware.org, Joel Brobecker References: <20190513092700.GA9733@delia> <87ef4hxg4j.fsf@tromey.com> From: Tom de Vries Openpgp: preference=signencrypt Message-ID: <28238d42-4db2-8733-67fb-9072526242b3@suse.de> Date: Thu, 18 Jul 2019 14:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87ef4hxg4j.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00434.txt.bz2 On 29-05-19 20:36, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> 2019-05-11 Tom de Vries > > Tom> PR symtab/24545 > Tom> * symtab.c (struct demangled_name_entry): Add language field. > Tom> (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate > Tom> static minimal symbol". Set and use language field. > > Thanks for doing this. > > Tom> + char *demangled_name = symbol_find_demangled_name (gsymbol, > Tom> + linkage_name_copy); > > I think it would be better to do > > gdb::unique_xmalloc_ptr demangled_name (...); > > and then adjust the code to use ".get ()" as needed. > > This is ok with that change. Is this also ok for 8.3.1? The patch applies cleanly. Thanks, - Tom