From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28637 invoked by alias); 29 May 2019 18:36:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28624 invoked by uid 89); 29 May 2019 18:36:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.151.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 May 2019 18:36:14 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 3B7C76706 for ; Wed, 29 May 2019 13:36:13 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id W3QrhtJai4FKpW3QrhEVYo; Wed, 29 May 2019 13:36:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3dnJ2zT+Yeu7xvT+2oSw+pomBYc/LXKTwx/qSg9ve0A=; b=LrTk9OVsE7TOG0VzXlXl+nlTFr 4EUrg4zmGdmLbgfg8GV+uRwNrD18tHz3Pbgp5q7KqWoRTxDG/ETniY4u2xpqLT5ezc0+RqG1rRxok DqqqJA9KuPNEp3tvw2VtMAOPf; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:46434 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hW3Qq-001uox-VW; Wed, 29 May 2019 13:36:13 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/symtab] Fix symbol loading performance regression References: <20190513092700.GA9733@delia> Date: Wed, 29 May 2019 18:36:00 -0000 In-Reply-To: <20190513092700.GA9733@delia> (Tom de Vries's message of "Mon, 13 May 2019 11:27:02 +0200") Message-ID: <87ef4hxg4j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00654.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> 2019-05-11 Tom de Vries Tom> PR symtab/24545 Tom> * symtab.c (struct demangled_name_entry): Add language field. Tom> (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate Tom> static minimal symbol". Set and use language field. Thanks for doing this. Tom> + char *demangled_name = symbol_find_demangled_name (gsymbol, Tom> + linkage_name_copy); I think it would be better to do gdb::unique_xmalloc_ptr demangled_name (...); and then adjust the code to use ".get ()" as needed. This is ok with that change. Tom