Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Christian Biesinger <cbiesinger@google.com>,
	 Simon Marchi <simon.marchi@polymtl.ca>,
	 gdb-patches@sourceware.org,  palves@redhat.com
Subject: Re: gnulib stat problem
Date: Tue, 14 Jan 2020 19:06:00 -0000	[thread overview]
Message-ID: <87eew19a40.fsf@tromey.com> (raw)
In-Reply-To: <87imle7z8x.fsf_-_@tromey.com> (Tom Tromey's message of "Tue, 14	Jan 2020 09:56:46 -0700")

Tom> Maybe gdb could *only* use bfd_get_mtime when it matters.  This would
Tom> mean changing gdb_bfd_open to create a BFD before checking the cache,
Tom> but maybe that's not very expensive.

I implemented this.  This approach seems pretty nice.

Also, I discovered that bfd_stat exists, which means we could also put
target BFDs into the cache -- currently we only put local ones there.
So, this seems like another plus (though I haven't implemented this
caching yet), and provides an additional reason to go this route.

Tom


  parent reply	other threads:[~2020-01-14 18:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-17  6:05 [review] Update Gnulib to the latest git version Christian Biesinger (Code Review)
2019-11-17 20:19 ` [review v2] " Christian Biesinger (Code Review)
2019-11-17 20:30 ` [review v3] " Christian Biesinger (Code Review)
2019-11-18  2:32 ` [review v4] " Christian Biesinger (Code Review)
2019-11-18 19:14 ` [review v5] " Christian Biesinger (Code Review)
2019-11-18 19:16 ` Christian Biesinger (Code Review)
2019-11-18 19:36 ` Simon Marchi (Code Review)
2019-11-18 20:02 ` [review v6] " Christian Biesinger (Code Review)
2019-11-18 20:03 ` [review v7] " Christian Biesinger (Code Review)
2019-11-18 20:03 ` Christian Biesinger (Code Review)
2019-11-18 20:12 ` [review v8] " Christian Biesinger (Code Review)
2019-11-18 20:50 ` [review v9] " Christian Biesinger (Code Review)
2019-11-18 20:59 ` [review v10] " Christian Biesinger (Code Review)
2019-11-18 21:10 ` Simon Marchi (Code Review)
2019-11-18 21:12 ` Simon Marchi (Code Review)
2019-11-18 21:17 ` [review v11] " Christian Biesinger (Code Review)
2019-11-18 21:18 ` Christian Biesinger (Code Review)
2019-11-21 22:33 ` [review v12] " Christian Biesinger (Code Review)
2019-11-22 23:47 ` Christian Biesinger (Code Review)
2019-11-25 23:34 ` [review v13] " Christian Biesinger (Code Review)
2019-11-26  4:40 ` Simon Marchi (Code Review)
2019-11-26 13:51 ` Tom Tromey (Code Review)
2019-11-26 17:28 ` Christian Biesinger (Code Review)
2019-12-06 20:18 ` Pedro Alves (Code Review)
2019-12-06 20:22 ` Christian Biesinger (Code Review)
2019-12-09 18:57 ` [review v14] " Christian Biesinger (Code Review)
2019-12-13 22:25 ` Tom Tromey (Code Review)
2019-12-16 18:17 ` [review v15] " Christian Biesinger (Code Review)
2019-12-16 18:18 ` Christian Biesinger (Code Review)
2019-12-16 18:22 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2020-01-14 17:03   ` gnulib stat problem (Was: [pushed] Update Gnulib to the latest git version) Tom Tromey
2020-01-14 17:32     ` Hannes Domani via gdb-patches
2020-01-14 19:06     ` Tom Tromey [this message]
2020-01-14 21:10     ` Eli Zaretskii
2019-12-16 18:22 ` [pushed] Update Gnulib to the latest git version Sourceware to Gerrit sync (Code Review)
2019-12-16 19:28 ` [review v16] " Pedro Alves (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eew19a40.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox