[review v5] Update Gnulib to the latest git version

Simon Marchi (Code Review)
2019-11-18T19:36:23Z

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/681
......................................................................

Patch Set 5:

(1 comment)

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +13,22 @@ https://lists.gnu.org/archive/html/bug-gnulib/2019-11/msg00024.html
| +All of GDB's local Gnulib patches were already fixed upstream per their
| +descriptions, so this patch removes them all.
| +
| +The problem listed here:
| +https://sourceware.org/ml/gdb-patches/2019-08/msg00553.html
| +was probably partially fixed by moving gnulib to the toplevel;
| +however, to fix the remaining issues I had to add a local patch
| +to override $(CC) in import/Makefile.am. Here is the rationale:
| +
| + The toplevel makefile overrides $(CC) (in EXTRA_HOST_FLAGS), which breaks
| + in Gnulib with older GCCs, because it uses this variable to store the
| + C11 flag (-std=gnu11). Override it here so we always get the value
| + from configure.

PS5, Line 25:

In case somebody wants to reproduce the problem, it would be good to
mention that this happens with compilers that don't use c99 by
default, like gcc 4.8.5 on Centos 7.

| +
| +gdb/ChangeLog:
| +
| +2019-11-17 Christian Biesinger <cbiesinger@google.com>
| +
| + * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
| + (we no longer need to include time.h before pathmax.h)
| +
| +gnulib/ChangeLog:

--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9c2b07a3046baecfb664e21b2644353ea888dbfa
Gerrit-Change-Number: 681
Gerrit-PatchSet: 5
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Mon, 18 Nov 2019 19:36:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment