From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Subject: [review v5] Update Gnulib to the latest git version
Date: Mon, 18 Nov 2019 19:36:00 -0000 [thread overview]
Message-ID: <20191118193613.8FF8E2816F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573970717000.I9c2b07a3046baecfb664e21b2644353ea888dbfa@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/681
......................................................................
Patch Set 5:
(1 comment)
| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +13,22 @@ https://lists.gnu.org/archive/html/bug-gnulib/2019-11/msg00024.html
| +All of GDB's local Gnulib patches were already fixed upstream per their
| +descriptions, so this patch removes them all.
| +
| +The problem listed here:
| +https://sourceware.org/ml/gdb-patches/2019-08/msg00553.html
| +was probably partially fixed by moving gnulib to the toplevel;
| +however, to fix the remaining issues I had to add a local patch
| +to override $(CC) in import/Makefile.am. Here is the rationale:
| +
| + The toplevel makefile overrides $(CC) (in EXTRA_HOST_FLAGS), which breaks
| + in Gnulib with older GCCs, because it uses this variable to store the
| + C11 flag (-std=gnu11). Override it here so we always get the value
| + from configure.
PS5, Line 25:
In case somebody wants to reproduce the problem, it would be good to
mention that this happens with compilers that don't use c99 by
default, like gcc 4.8.5 on Centos 7.
| +
| +gdb/ChangeLog:
| +
| +2019-11-17 Christian Biesinger <cbiesinger@google.com>
| +
| + * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
| + (we no longer need to include time.h before pathmax.h)
| +
| +gnulib/ChangeLog:
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9c2b07a3046baecfb664e21b2644353ea888dbfa
Gerrit-Change-Number: 681
Gerrit-PatchSet: 5
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Mon, 18 Nov 2019 19:36:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-18 19:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 6:05 [review] " Christian Biesinger (Code Review)
2019-11-17 20:19 ` [review v2] " Christian Biesinger (Code Review)
2019-11-17 20:30 ` [review v3] " Christian Biesinger (Code Review)
2019-11-18 2:32 ` [review v4] " Christian Biesinger (Code Review)
2019-11-18 19:14 ` [review v5] " Christian Biesinger (Code Review)
2019-11-18 19:16 ` Christian Biesinger (Code Review)
2019-11-18 19:36 ` Simon Marchi (Code Review) [this message]
2019-11-18 20:02 ` [review v6] " Christian Biesinger (Code Review)
2019-11-18 20:03 ` [review v7] " Christian Biesinger (Code Review)
2019-11-18 20:03 ` Christian Biesinger (Code Review)
2019-11-18 20:12 ` [review v8] " Christian Biesinger (Code Review)
2019-11-18 20:50 ` [review v9] " Christian Biesinger (Code Review)
2019-11-18 20:59 ` [review v10] " Christian Biesinger (Code Review)
2019-11-18 21:10 ` Simon Marchi (Code Review)
2019-11-18 21:12 ` Simon Marchi (Code Review)
2019-11-18 21:17 ` [review v11] " Christian Biesinger (Code Review)
2019-11-18 21:18 ` Christian Biesinger (Code Review)
2019-11-21 22:33 ` [review v12] " Christian Biesinger (Code Review)
2019-11-22 23:47 ` Christian Biesinger (Code Review)
2019-11-25 23:34 ` [review v13] " Christian Biesinger (Code Review)
2019-11-26 4:40 ` Simon Marchi (Code Review)
2019-11-26 13:51 ` Tom Tromey (Code Review)
2019-11-26 17:28 ` Christian Biesinger (Code Review)
2019-12-06 20:18 ` Pedro Alves (Code Review)
2019-12-06 20:22 ` Christian Biesinger (Code Review)
2019-12-09 18:57 ` [review v14] " Christian Biesinger (Code Review)
2019-12-13 22:25 ` Tom Tromey (Code Review)
2019-12-16 18:17 ` [review v15] " Christian Biesinger (Code Review)
2019-12-16 18:18 ` Christian Biesinger (Code Review)
2019-12-16 18:22 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-16 18:22 ` Sourceware to Gerrit sync (Code Review)
2020-01-14 17:03 ` gnulib stat problem (Was: [pushed] Update Gnulib to the latest git version) Tom Tromey
2020-01-14 17:32 ` Hannes Domani via gdb-patches
2020-01-14 19:06 ` gnulib stat problem Tom Tromey
2020-01-14 21:10 ` gnulib stat problem (Was: [pushed] Update Gnulib to the latest git version) Eli Zaretskii
2019-12-16 19:28 ` [review v16] Update Gnulib to the latest git version Pedro Alves (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118193613.8FF8E2816F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox