From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] wrong language used when re-setting breakpoint
Date: Tue, 18 Sep 2012 17:36:00 -0000 [thread overview]
Message-ID: <87d31jxmfw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120918150542.GD3276@adacore.com> (Joel Brobecker's message of "Tue, 18 Sep 2012 08:05:43 -0700")
Joel> I kind of agree, but ... at the same time, this type of changes then
Joel> makes it harder for us to make progress in getting rid of the
Joel> current_language global, no?
Nope, sorry, what I'm suggesting is diagnosing and fixing this problem
first, then putting your patch in subsequently.
Joel> Also, I think that relying on the global being set for a defined period
Joel> of time is a little risky. It seems too easy for the current_language
Joel> to change right from under us as a side-effect of some sub-action.
Yes, I agree, and I think that's why the direction linespec is headed is
a good one. But, temporarily setting current_language is how gdb has
worked for a long time, and if that broke, it probably means a
regression or bug elsewhere. And, linespec isn't actually fully
parameterized like this anyway.
Tom
next prev parent reply other threads:[~2012-09-18 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 0:40 Joel Brobecker
2012-09-18 14:52 ` Tom Tromey
2012-09-18 15:06 ` Joel Brobecker
2012-09-18 17:36 ` Tom Tromey [this message]
2012-09-18 17:47 ` Tom Tromey
2012-09-18 18:18 ` Joel Brobecker
2012-09-18 18:26 ` Tom Tromey
2012-09-18 18:55 ` Joel Brobecker
2012-09-18 19:16 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d31jxmfw.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox