Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] wrong language used when re-setting breakpoint
Date: Tue, 18 Sep 2012 18:18:00 -0000	[thread overview]
Message-ID: <20120918181839.GF3276@adacore.com> (raw)
In-Reply-To: <878vc7xlxu.fsf@fleche.redhat.com>

> I was going to look into the issue, but I reverted the linespec.c change
> locally but bp_reset.exp still passes.  I do have a valid
> debug-file-directory.  Is there something else I need to do to see the
> failure?

I think it's very sensitive to which modules you have in your
debug-file-directory. The machine on which I reproduced the testcase
has a ton of stuff in there, and I didn't spend the time to figure out
which one it is that causes the problem.

That being said, when doing the same, I discovered that the testcase
indeed passes without my patch. I did the investigation and patching
using an older version of GDB, and simply merged it when it came to
submitting it. I didn't think of running the testcase without my patch
with the HEAD!

A recent change must have disturbed a little the balance. I'll try
looking into it a little deeper. Do you think I should revert my patch?

-- 
Joel


  reply	other threads:[~2012-09-18 18:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18  0:40 Joel Brobecker
2012-09-18 14:52 ` Tom Tromey
2012-09-18 15:06   ` Joel Brobecker
2012-09-18 17:36     ` Tom Tromey
2012-09-18 17:47     ` Tom Tromey
2012-09-18 18:18       ` Joel Brobecker [this message]
2012-09-18 18:26         ` Tom Tromey
2012-09-18 18:55           ` Joel Brobecker
2012-09-18 19:16             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120918181839.GF3276@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox