Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] wrong language used when re-setting breakpoint
Date: Tue, 18 Sep 2012 15:06:00 -0000	[thread overview]
Message-ID: <20120918150542.GD3276@adacore.com> (raw)
In-Reply-To: <87k3vrxu2o.fsf@fleche.redhat.com>

> I think the breakpoint re-setting code should be temporarily setting
> current_language.  breakpoint_re_set does this.

I kind of agree, but ... at the same time, this type of changes then
makes it harder for us to make progress in getting rid of the
current_language global, no?

Also, I think that relying on the global being set for a defined period
of time is a little risky. It seems too easy for the current_language
to change right from under us as a side-effect of some sub-action.

> I don't have a problem with your patch.  I think it is an improvement.
> But I think it is important to understand why the current mechanism
> isn't working, since I think a failure here may have other bad effects
> as well.

OK - I will commit the patch, then. But I think we'd be better off
trying to find the other bad effects, and see if we can use a parameter
to fix them, rather than making sure the global is set properly.
The problem with my suggested approach, however, is that we have
to wait for bugs that reveal those bad effects.

Thanks,
-- 
Joel


  reply	other threads:[~2012-09-18 15:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18  0:40 Joel Brobecker
2012-09-18 14:52 ` Tom Tromey
2012-09-18 15:06   ` Joel Brobecker [this message]
2012-09-18 17:36     ` Tom Tromey
2012-09-18 17:47     ` Tom Tromey
2012-09-18 18:18       ` Joel Brobecker
2012-09-18 18:26         ` Tom Tromey
2012-09-18 18:55           ` Joel Brobecker
2012-09-18 19:16             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120918150542.GD3276@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox