From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA v2 2/2] Fix PR python/17386 - add __index__ method to gdb.Value
Date: Mon, 23 May 2016 18:40:00 -0000 [thread overview]
Message-ID: <87d1ocwrd5.fsf@tromey.com> (raw)
In-Reply-To: <dfa852ae-9f73-0a4c-4460-1eba3d00fe4d@redhat.com> (Pedro Alves's message of "Mon, 23 May 2016 19:01:00 +0100")
>> +#ifndef HAVE_LIBPYTHON_2_4
>> + /* This was added in Python 2.5. */
>> + , valpy_long /* nb_index */
>> +#endif /* HAVE_LIBPYTHON_2_4 */
Pedro> Are you trying to avoid a trailing comma?
Yep.
Pedro> IOW, this can be:
I fixed it locally, thanks.
Tom
next prev parent reply other threads:[~2016-05-23 18:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 17:25 [RFA v2 0/2] " Tom Tromey
2016-05-23 17:25 ` [RFA v2 1/2] add nb_inplace_divide for python 2 Tom Tromey
2016-05-24 8:50 ` Yao Qi
2016-05-23 17:25 ` [RFA v2 2/2] Fix PR python/17386 - add __index__ method to gdb.Value Tom Tromey
2016-05-23 18:01 ` Pedro Alves
2016-05-23 18:40 ` Tom Tromey [this message]
2016-05-24 8:58 ` Yao Qi
2016-05-25 13:48 ` Ulrich Weigand
2016-05-25 14:04 ` Tom Tromey
2016-05-25 14:54 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1ocwrd5.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox