From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114789 invoked by alias); 23 May 2016 18:40:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114776 invoked by uid 89); 23 May 2016 18:40:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 23 May 2016 18:40:20 +0000 Received: (qmail 12623 invoked by uid 0); 23 May 2016 18:40:19 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy6.mail.unifiedlayer.com with SMTP; 23 May 2016 18:40:19 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id xufs1s00w2f2jeq01ufv9A; Mon, 23 May 2016 12:40:17 -0600 X-Authority-Analysis: v=2.1 cv=FPeImYYs c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=_v2sUkyEFrwA:10 a=yrkiwgmsf1kA:10 a=p-YA_m_bSJvS8pXXJe0A:9 a=P5CcA3VncIUA:10 Received: from [71.215.116.141] (port=48596 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86_2) (envelope-from ) id 1b4uld-0002Ih-Mr; Mon, 23 May 2016 12:39:53 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 2/2] Fix PR python/17386 - add __index__ method to gdb.Value References: <1464024313-11932-1-git-send-email-tom@tromey.com> <1464024313-11932-3-git-send-email-tom@tromey.com> Date: Mon, 23 May 2016 18:40:00 -0000 In-Reply-To: (Pedro Alves's message of "Mon, 23 May 2016 19:01:00 +0100") Message-ID: <87d1ocwrd5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 71.215.116.141 authed with tom+tromey.com} X-SW-Source: 2016-05/txt/msg00407.txt.bz2 >> +#ifndef HAVE_LIBPYTHON_2_4 >> + /* This was added in Python 2.5. */ >> + , valpy_long /* nb_index */ >> +#endif /* HAVE_LIBPYTHON_2_4 */ Pedro> Are you trying to avoid a trailing comma? Yep. Pedro> IOW, this can be: I fixed it locally, thanks. Tom