Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: tom@tromey.com (Tom Tromey)
Cc: gdb-patches@sourceware.org, tom@tromey.com (Tom Tromey)
Subject: Re: [RFA v2 2/2] Fix PR python/17386 - add __index__ method to gdb.Value
Date: Wed, 25 May 2016 13:48:00 -0000	[thread overview]
Message-ID: <20160525134757.2D266F97D@oc7340732750.ibm.com> (raw)
In-Reply-To: <1464024313-11932-3-git-send-email-tom@tromey.com> from "Tom Tromey" at May 23, 2016 11:25:13 AM

Tom Tromey wrote:

> 	PR python/17386:
> 	* python/py-value.c (value_object_as_number): Add
> 	nb_inplace_floor_divide, nb_inplace_true_divide, nb_index.

This causes a failure on my RHEL5 test system (using Python 2.4):
gdb/python/py-value.c:1848: error: too many initializers for ‘PyNumberMethods’

> +#ifndef HAVE_LIBPYTHON_2_4
> +  /* This was added in Python 2.5.  */
> +  , valpy_long		      /* nb_index */
> +#endif /* HAVE_LIBPYTHON_2_4 */

Nothing defines HAVE_LIBPYTHON_2_4 on my machine; instead, we seem to have

/* Define if Python 2.4 is being used. */
#define HAVE_LIBPYTHON2_4 1

in config.h ...  Typo?

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


  parent reply	other threads:[~2016-05-25 13:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23 17:25 [RFA v2 0/2] " Tom Tromey
2016-05-23 17:25 ` [RFA v2 1/2] add nb_inplace_divide for python 2 Tom Tromey
2016-05-24  8:50   ` Yao Qi
2016-05-23 17:25 ` [RFA v2 2/2] Fix PR python/17386 - add __index__ method to gdb.Value Tom Tromey
2016-05-23 18:01   ` Pedro Alves
2016-05-23 18:40     ` Tom Tromey
2016-05-24  8:58   ` Yao Qi
2016-05-25 13:48   ` Ulrich Weigand [this message]
2016-05-25 14:04     ` Tom Tromey
2016-05-25 14:54       ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160525134757.2D266F97D@oc7340732750.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox