From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89367 invoked by alias); 25 May 2016 13:48:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89353 invoked by uid 89); 25 May 2016 13:48:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*x:2.5, H*UA:2.5, Hx-languages-length:779, H*UA:version X-HELO: e06smtp15.uk.ibm.com Received: from e06smtp15.uk.ibm.com (HELO e06smtp15.uk.ibm.com) (195.75.94.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 25 May 2016 13:48:02 +0000 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 May 2016 14:47:59 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 25 May 2016 14:47:58 +0100 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id E7BCE2190061 for ; Wed, 25 May 2016 14:47:31 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u4PDlv4A14680450 for ; Wed, 25 May 2016 13:47:57 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u4PDlvke005492 for ; Wed, 25 May 2016 09:47:57 -0400 Received: from oc7340732750.ibm.com (dyn-9-152-213-42.boeblingen.de.ibm.com [9.152.213.42]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u4PDlvv4005486; Wed, 25 May 2016 09:47:57 -0400 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 2D266F97D; Wed, 25 May 2016 15:47:57 +0200 (CEST) Subject: Re: [RFA v2 2/2] Fix PR python/17386 - add __index__ method to gdb.Value To: tom@tromey.com (Tom Tromey) Date: Wed, 25 May 2016 13:48:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, tom@tromey.com (Tom Tromey) In-Reply-To: <1464024313-11932-3-git-send-email-tom@tromey.com> from "Tom Tromey" at May 23, 2016 11:25:13 AM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20160525134757.2D266F97D@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16052513-0021-0000-0000-00003BFB319F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused X-SW-Source: 2016-05/txt/msg00444.txt.bz2 Tom Tromey wrote: > PR python/17386: > * python/py-value.c (value_object_as_number): Add > nb_inplace_floor_divide, nb_inplace_true_divide, nb_index. This causes a failure on my RHEL5 test system (using Python 2.4): gdb/python/py-value.c:1848: error: too many initializers for ‘PyNumberMethods’ > +#ifndef HAVE_LIBPYTHON_2_4 > + /* This was added in Python 2.5. */ > + , valpy_long /* nb_index */ > +#endif /* HAVE_LIBPYTHON_2_4 */ Nothing defines HAVE_LIBPYTHON_2_4 on my machine; instead, we seem to have /* Define if Python 2.4 is being used. */ #define HAVE_LIBPYTHON2_4 1 in config.h ... Typo? Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com