Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv2 3/5] gdb: Introduce new language field la_struct_too_deep_ellipsis
Date: Fri, 19 Apr 2019 14:37:00 -0000	[thread overview]
Message-ID: <87d0lidpse.fsf@tromey.com> (raw)
In-Reply-To: <f12abaeca35a2e7d9fde7a5553931f5a053abe72.1555455013.git.andrew.burgess@embecosm.com>	(Andrew Burgess's message of "Wed, 17 Apr 2019 00:06:08 +0100")

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> In this commit I add the new field and initialise it for each
Andrew> language, however at this stage the new field is never used.

Andrew> gdb/ChangeLog:

Andrew> 	* language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
Andrew> 	New field.
Andrew> 	* ada-lang.c (ada_language_defn): Initialise new field.
Andrew> 	* c-lang.c (c_language_defn): Likewise.
Andrew> 	(cplus_language_defn): Likewise.
Andrew> 	(asm_language_defn): Likewise.
Andrew> 	(minimal_language_defn): Likewise.
Andrew> 	* d-lang.c (d_language_defn): Likewise.
Andrew> 	* f-lang.c (f_language_defn): Likewise.
Andrew> 	* go-lang.c (go_language_defn): Likewise.
Andrew> 	* language.c (unknown_language_defn): Likewise.
Andrew> 	(auto_language_defn): Likewise.
Andrew> 	* m2-lang.c (m2_language_defn): Likewise.
Andrew> 	* objc-lang.c (objc_language_defn): Likewise.
Andrew> 	* opencl-lang.c (opencl_language_defn): Likewise.
Andrew> 	* p-lang.c (pascal_language_defn): Likewise.
Andrew> 	* rust-lang.c (rust_language_defn): Likewise.

This looks good to me, thanks.

Tom


  reply	other threads:[~2019-04-19 14:37 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16 23:06 [PATCHv2 0/5] Add new 'print max-depth' feature Andrew Burgess
2019-03-27 21:53 ` [PATCH 0/2] " Andrew Burgess
2019-03-27 21:53   ` [PATCH 2/2] gdb: Introduce " Andrew Burgess
2019-03-28 16:08     ` Eli Zaretskii
2019-03-27 21:53   ` [PATCH 1/2] gdb: Introduce new language field la_struct_too_deep_ellipsis Andrew Burgess
2019-03-28 12:43     ` Pedro Alves
2019-03-28 12:47   ` [PATCH 0/2] Add new 'print max-depth' feature Pedro Alves
2019-03-28 22:48     ` Andrew Burgess
2019-03-28 23:47       ` Marco Barisione
2019-04-16 23:06   ` [PATCHv2 1/5] gdb/ada: Update some predicate functions to return bool Andrew Burgess
2019-04-18  0:03     ` Joel Brobecker
2019-04-16 23:06   ` [PATCHv2 5/5] gdb: Introduce 'print max-depth' feature Andrew Burgess
2019-04-17  7:42     ` Philippe Waroquiers
2019-04-17 14:35     ` Eli Zaretskii
2019-04-18  1:07       ` Andrew Burgess
2019-04-18  2:38         ` Eli Zaretskii
2019-04-18 21:52           ` Andrew Burgess
2019-04-19  6:50             ` Eli Zaretskii
2019-04-18 17:08     ` Pedro Alves
2019-04-16 23:06   ` [PATCHv2 3/5] gdb: Introduce new language field la_struct_too_deep_ellipsis Andrew Burgess
2019-04-19 14:37     ` Tom Tromey [this message]
2019-04-16 23:06   ` [PATCHv2 2/5] gdb/testsuite: Don't add gcc flags when compiling rust tests Andrew Burgess
2019-04-19 14:31     ` Tom Tromey
2019-04-16 23:06   ` [PATCHv2 4/5] gdb: Introduce new language field la_is_string_type_p Andrew Burgess
2019-04-18 17:08     ` Pedro Alves
2019-04-19 21:00       ` Andrew Burgess
2019-04-19 14:45     ` Tom Tromey
2019-04-19 22:22       ` Andrew Burgess
2019-04-24 19:32         ` Tom Tromey
2019-04-19 22:45       ` Andrew Burgess
2019-04-24 19:33         ` Tom Tromey
2019-04-29 21:14 ` [PATCHv2 0/5] Add new 'print max-depth' feature Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0lidpse.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox