From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3037 invoked by alias); 19 Apr 2019 14:37:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2965 invoked by uid 89); 19 Apr 2019 14:37:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_40,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1194, ada-lang.c, UD:ada-lang.c, adalangc X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Apr 2019 14:37:40 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 583EA113EB for ; Fri, 19 Apr 2019 09:37:38 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id HUe2hdVYuiQerHUe2hLTes; Fri, 19 Apr 2019 09:37:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rbWpivRrWMn18MDspRp7pHiaUl0Olae+qzaab2YLFzQ=; b=MvkJCnObUjH87EI2gInxbBJCeO ppDuu/TuqniLZMql13u3SaFpJbF9sTpv9jEXfCFk0kEyRojNYRxkwoiIPbWRczTUgzg+cDwWn7ugL yevW5YXeK4kTpXbqqQN0fCW3l; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:56330 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hHUe2-000Sjq-4u; Fri, 19 Apr 2019 09:37:38 -0500 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2 3/5] gdb: Introduce new language field la_struct_too_deep_ellipsis References: Date: Fri, 19 Apr 2019 14:37:00 -0000 In-Reply-To: (Andrew Burgess's message of "Wed, 17 Apr 2019 00:06:08 +0100") Message-ID: <87d0lidpse.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00379.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> In this commit I add the new field and initialise it for each Andrew> language, however at this stage the new field is never used. Andrew> gdb/ChangeLog: Andrew> * language.h (struct language_defn) : Andrew> New field. Andrew> * ada-lang.c (ada_language_defn): Initialise new field. Andrew> * c-lang.c (c_language_defn): Likewise. Andrew> (cplus_language_defn): Likewise. Andrew> (asm_language_defn): Likewise. Andrew> (minimal_language_defn): Likewise. Andrew> * d-lang.c (d_language_defn): Likewise. Andrew> * f-lang.c (f_language_defn): Likewise. Andrew> * go-lang.c (go_language_defn): Likewise. Andrew> * language.c (unknown_language_defn): Likewise. Andrew> (auto_language_defn): Likewise. Andrew> * m2-lang.c (m2_language_defn): Likewise. Andrew> * objc-lang.c (objc_language_defn): Likewise. Andrew> * opencl-lang.c (opencl_language_defn): Likewise. Andrew> * p-lang.c (pascal_language_defn): Likewise. Andrew> * rust-lang.c (rust_language_defn): Likewise. This looks good to me, thanks. Tom