From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCHv2 2/5] gdb/testsuite: Don't add gcc flags when compiling rust tests
Date: Tue, 16 Apr 2019 23:06:00 -0000 [thread overview]
Message-ID: <ebb84b63ff5c613c6177bead989c0d5b00bae5b4.1555455013.git.andrew.burgess@embecosm.com> (raw)
In-Reply-To: <cover.1555455013.git.andrew.burgess@embecosm.com>
In-Reply-To: <cover.1555455013.git.andrew.burgess@embecosm.com>
We currently add the -fno-stack-protector option to the compiler flags
when compiling rust tests, as this is not a valid rustcc flag, this
means non of the test tests will compile.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (gdb_compile): Don't add -fno-stack-protector option
if we're using rustcc.
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/lib/gdb.exp | 6 +++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 1176fdded14..6c0f243eef8 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3566,7 +3566,11 @@ proc gdb_compile {source dest type options} {
&& !([test_compiler_info {gcc-[0-3]-*}]
|| [test_compiler_info {gcc-4-0-*}]) } {
# Put it at the front to not override any user-provided value.
- lappend new_options "early_flags=-fno-stack-protector"
+ if {[lsearch -exact $options rust] != -1} {
+ # -fno-stack-protector is not a rustcc option.
+ } else {
+ lappend new_options "early_flags=-fno-stack-protector"
+ }
}
# Because we link with libraries using their basename, we may need
--
2.14.5
next prev parent reply other threads:[~2019-04-16 23:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 23:06 [PATCHv2 0/5] Add new 'print max-depth' feature Andrew Burgess
2019-03-27 21:53 ` [PATCH 0/2] " Andrew Burgess
2019-03-27 21:53 ` [PATCH 2/2] gdb: Introduce " Andrew Burgess
2019-03-28 16:08 ` Eli Zaretskii
2019-03-27 21:53 ` [PATCH 1/2] gdb: Introduce new language field la_struct_too_deep_ellipsis Andrew Burgess
2019-03-28 12:43 ` Pedro Alves
2019-03-28 12:47 ` [PATCH 0/2] Add new 'print max-depth' feature Pedro Alves
2019-03-28 22:48 ` Andrew Burgess
2019-03-28 23:47 ` Marco Barisione
2019-04-16 23:06 ` [PATCHv2 1/5] gdb/ada: Update some predicate functions to return bool Andrew Burgess
2019-04-18 0:03 ` Joel Brobecker
2019-04-16 23:06 ` [PATCHv2 4/5] gdb: Introduce new language field la_is_string_type_p Andrew Burgess
2019-04-18 17:08 ` Pedro Alves
2019-04-19 21:00 ` Andrew Burgess
2019-04-19 14:45 ` Tom Tromey
2019-04-19 22:22 ` Andrew Burgess
2019-04-24 19:32 ` Tom Tromey
2019-04-19 22:45 ` Andrew Burgess
2019-04-24 19:33 ` Tom Tromey
2019-04-16 23:06 ` [PATCHv2 5/5] gdb: Introduce 'print max-depth' feature Andrew Burgess
2019-04-17 7:42 ` Philippe Waroquiers
2019-04-17 14:35 ` Eli Zaretskii
2019-04-18 1:07 ` Andrew Burgess
2019-04-18 2:38 ` Eli Zaretskii
2019-04-18 21:52 ` Andrew Burgess
2019-04-19 6:50 ` Eli Zaretskii
2019-04-18 17:08 ` Pedro Alves
2019-04-16 23:06 ` Andrew Burgess [this message]
2019-04-19 14:31 ` [PATCHv2 2/5] gdb/testsuite: Don't add gcc flags when compiling rust tests Tom Tromey
2019-04-16 23:06 ` [PATCHv2 3/5] gdb: Introduce new language field la_struct_too_deep_ellipsis Andrew Burgess
2019-04-19 14:37 ` Tom Tromey
2019-04-29 21:14 ` [PATCHv2 0/5] Add new 'print max-depth' feature Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebb84b63ff5c613c6177bead989c0d5b00bae5b4.1555455013.git.andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox