From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] Make use of gdb::options for info variabels|functions|args|locals
Date: Thu, 11 Jul 2019 16:08:00 -0000 [thread overview]
Message-ID: <87d0igbll7.fsf@tromey.com> (raw)
In-Reply-To: <20190711155305.GO23204@embecosm.com> (Andrew Burgess's message of "Thu, 11 Jul 2019 16:53:05 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> +void
Andrew> +info_print_command_completer (struct cmd_list_element *ignore,
Andrew> + completion_tracker &tracker,
Andrew> + const char *text, const char * /* word */)
Andrew> +{
Andrew> + const auto group
Andrew> + = make_info_print_options_def_group (nullptr);
Andrew> + if (gdb::option::complete_options
Andrew> + (tracker, &text, gdb::option::PROCESS_OPTIONS_UNKNOWN_IS_OPERAND, group))
Andrew> + return;
Andrew> +
Andrew> + const char *word = advance_to_expression_complete_word_point (tracker, text);
Andrew> + symbol_completer (ignore, tracker, text, word);
Andrew> + return;
Andrew> +}
I didn't really read the patch but this unnecessary return popped out at me.
I think gdb style is not to do this.
Tom
prev parent reply other threads:[~2019-07-11 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 13:21 Andrew Burgess
2019-07-11 13:21 ` [PATCH 1/2] gdb: Allow quoting around string options in the gdb::option framework Andrew Burgess
2019-07-11 16:17 ` Tom Tromey
2019-07-11 19:21 ` Andrew Burgess
2019-07-11 13:21 ` [PATCH 2/2] gdb: Make use of gdb::option framework for some info commands Andrew Burgess
2019-07-11 13:36 ` [PATCH 0/2] Make use of gdb::options for info variabels|functions|args|locals Pedro Alves
2019-07-11 15:53 ` Andrew Burgess
2019-07-11 16:05 ` Pedro Alves
2019-07-11 19:21 ` Andrew Burgess
2019-07-11 16:08 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0igbll7.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox