From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101168 invoked by alias); 11 Jul 2019 16:08:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101160 invoked by uid 89); 11 Jul 2019 16:08:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=D*embecosm.com, andrewburgessembecosmcom, U*andrew.burgess, andrew.burgess@embecosm.com X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 16:08:23 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id BB226B86ABB for ; Thu, 11 Jul 2019 11:08:21 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id lbcLhzrXNYTGMlbcLhrIsD; Thu, 11 Jul 2019 11:08:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=12RLcOzZb1KrHLNHn9kXB2Fe5VCXEV+kNx7PV+8oDo0=; b=b8A9mcSEo046AWOL4D8iE3/8yh i00NbF2SH6We3rxKB8VjWj8Mk5Ju5I4HlB/QzMvy/NDQa/+jqOBBoADD5kFM+XlMZ2zyOzPaY3jTY iW86bBUw9dIARtDslq5Euw2I+; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:54630 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hlbcL-000XBM-Gx; Thu, 11 Jul 2019 11:08:21 -0500 From: Tom Tromey To: Andrew Burgess Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 0/2] Make use of gdb::options for info variabels|functions|args|locals References: <306a840c-719a-0398-26cd-34142ba05167@redhat.com> <20190711155305.GO23204@embecosm.com> Date: Thu, 11 Jul 2019 16:08:00 -0000 In-Reply-To: <20190711155305.GO23204@embecosm.com> (Andrew Burgess's message of "Thu, 11 Jul 2019 16:53:05 +0100") Message-ID: <87d0igbll7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00324.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> +void Andrew> +info_print_command_completer (struct cmd_list_element *ignore, Andrew> + completion_tracker &tracker, Andrew> + const char *text, const char * /* word */) Andrew> +{ Andrew> + const auto group Andrew> + = make_info_print_options_def_group (nullptr); Andrew> + if (gdb::option::complete_options Andrew> + (tracker, &text, gdb::option::PROCESS_OPTIONS_UNKNOWN_IS_OPERAND, group)) Andrew> + return; Andrew> + Andrew> + const char *word = advance_to_expression_complete_word_point (tracker, text); Andrew> + symbol_completer (ignore, tracker, text, word); Andrew> + return; Andrew> +} I didn't really read the patch but this unnecessary return popped out at me. I think gdb style is not to do this. Tom