From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: Allow quoting around string options in the gdb::option framework
Date: Thu, 11 Jul 2019 19:21:00 -0000 [thread overview]
Message-ID: <20190711192055.GP23204@embecosm.com> (raw)
In-Reply-To: <878st4bl5k.fsf@tromey.com>
* Tom Tromey <tom@tromey.com> [2019-07-11 10:17:43 -0600]:
> >>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
>
> Andrew> proc expect_string {str operand} {
> Andrew> + # Dequote the string in the expected output.
> Andrew> + if { ( [string range $str 0 0] == "\"" && [string range $str end end] == "\"") \
> Andrew> + || ([string range $str 0 0] == "'" && [string range $str end end] == "'")} {
>
> These lines look over-long.
> Also the trailing "\" isn't needed here.
Pushed with this fix.
Thanks,
Andrew
next prev parent reply other threads:[~2019-07-11 19:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 13:21 [PATCH 0/2] Make use of gdb::options for info variabels|functions|args|locals Andrew Burgess
2019-07-11 13:21 ` [PATCH 1/2] gdb: Allow quoting around string options in the gdb::option framework Andrew Burgess
2019-07-11 16:17 ` Tom Tromey
2019-07-11 19:21 ` Andrew Burgess [this message]
2019-07-11 13:21 ` [PATCH 2/2] gdb: Make use of gdb::option framework for some info commands Andrew Burgess
2019-07-11 13:36 ` [PATCH 0/2] Make use of gdb::options for info variabels|functions|args|locals Pedro Alves
2019-07-11 15:53 ` Andrew Burgess
2019-07-11 16:05 ` Pedro Alves
2019-07-11 19:21 ` Andrew Burgess
2019-07-11 16:08 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711192055.GP23204@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox