From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27663 invoked by alias); 11 Jul 2019 19:21:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27650 invoked by uid 89); 11 Jul 2019 19:21:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f66.google.com Received: from mail-wm1-f66.google.com (HELO mail-wm1-f66.google.com) (209.85.128.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 19:20:59 +0000 Received: by mail-wm1-f66.google.com with SMTP id h19so7646235wme.0 for ; Thu, 11 Jul 2019 12:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tR3WzK+10UhvoybywTCUReaje5DX6fQFFlu2vPk4nIw=; b=VMY0iIRUJRnXVeCI0U3pP3BALjQuejnsrNHHUN2m7/FBaBaWwN7YBcTROIhoVnScx1 W8GdjfSUWx8WfyVEL+UK2an0faHBojtjyJTkRRrUHkEcru0Ucaz4kj1OKo/AuS+Z6oj8 TSwhz4XujF767lImB4nMEt/QMwBnRI9gaxzpdR2CoLMjBc+ptDARPH2a8Dcwbj4f6SJc Q2pnn2qvIysZXyjPg5Y/gkSkA5bP5I1tkGQ8AQcn8MATOxkjIJrNj+Qfc39nPufLS8uP MEqjuDk8eksnB5ymgPa8bKIPFp9Du3KKN+d1r7kxQET2D6mD5GuJPIXKBzeariwY3bnP Iskg== Return-Path: Received: from localhost (host86-128-12-99.range86-128.btcentralplus.com. [86.128.12.99]) by smtp.gmail.com with ESMTPSA id u13sm6621762wrq.62.2019.07.11.12.20.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Jul 2019 12:20:56 -0700 (PDT) Date: Thu, 11 Jul 2019 19:21:00 -0000 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: Allow quoting around string options in the gdb::option framework Message-ID: <20190711192055.GP23204@embecosm.com> References: <56de17c8da0e7911f8b1e58d0192e19035f06916.1562850845.git.andrew.burgess@embecosm.com> <878st4bl5k.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878st4bl5k.fsf@tromey.com> X-Fortune: Failure to adjust for daylight savings time. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00334.txt.bz2 * Tom Tromey [2019-07-11 10:17:43 -0600]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> proc expect_string {str operand} { > Andrew> + # Dequote the string in the expected output. > Andrew> + if { ( [string range $str 0 0] == "\"" && [string range $str end end] == "\"") \ > Andrew> + || ([string range $str 0 0] == "'" && [string range $str end end] == "'")} { > > These lines look over-long. > Also the trailing "\" isn't needed here. Pushed with this fix. Thanks, Andrew