From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: replace FRAME_OBSTACK_{C, Z}ALLOC macros with templated functions
Date: Mon, 10 Nov 2025 18:14:23 -0300 [thread overview]
Message-ID: <87cy5pbnf4.fsf@linaro.org> (raw)
In-Reply-To: <20251110052145.1636979-1-simon.marchi@polymtl.ca> (simon marchi's message of "Mon, 10 Nov 2025 00:21:33 -0500")
simon.marchi@polymtl.ca writes:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> While reviewing a patch, I saw these macros and thought they could be
> modernized a bit.
Nice! Just one comment:
Most calls to the new functions don't use the 'struct' keyword, e.g.:
> - cache = FRAME_OBSTACK_ZALLOC (struct aarch64_prologue_cache);
> + auto *cache = frame_obstack_zalloc<aarch64_prologue_cache> ();
while some do, e.g.:
> - cache = FRAME_OBSTACK_ZALLOC (struct amd64_frame_cache);
> + auto *cache = frame_obstack_zalloc<struct amd64_frame_cache> ();
I suggest standardising on always omitting the struct keyword.
--
Thiago
next prev parent reply other threads:[~2025-11-10 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 5:21 simon.marchi
2025-11-10 21:14 ` Thiago Jung Bauermann [this message]
2025-11-10 21:24 ` Simon Marchi
2025-11-25 20:11 ` [PATCH] gdb: replace FRAME_OBSTACK_{C,Z}ALLOC " Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cy5pbnf4.fsf@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox