From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qQ9PA+JVEmksxTMAWB0awg (envelope-from ) for ; Mon, 10 Nov 2025 16:15:14 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=WDHbw87N; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 08EF41E0B8; Mon, 10 Nov 2025 16:15:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 983ED1E04C for ; Mon, 10 Nov 2025 16:15:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 391163858CB6 for ; Mon, 10 Nov 2025 21:15:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 391163858CB6 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=WDHbw87N Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id D74323858409 for ; Mon, 10 Nov 2025 21:14:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D74323858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D74323858409 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762809267; cv=none; b=yGNOeGfojEGCT5CGUlP9V56hFWnJHQevIH4yNQJ+L7GyFCBPlnQs2W11E8ZceWYIeh+ow86uT9RaoZC+omKaFGqkilTXH4BJd49unaeSJLRXULVA8milqh8eVu89dZbQFhHAgswVs1VXCnCIbdy+wlzkNANhl63rd6tXplwrmaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762809267; c=relaxed/simple; bh=HBHcjk5hAF1EK5md5PZqqt5ezl6UK41NxcwZaE8drE0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bXotOd8/NrLA2lAERtgIc8BuxOMGPvLypGJ+xnqOBZCTT3DMWU83Jmmv5fi4OitnlQ7sIFhhcTUM+89PJ9EPA0b00KZpQ5SQVKfLAbJmFQ9HhU2q2b7k9d9SHygeBn+AH1awRGDpjS2wvb7AO2rev+Zb9+6/6woqRvF4WVx6H6w= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D74323858409 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-33ff5149ae8so2110232a91.3 for ; Mon, 10 Nov 2025 13:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762809266; x=1763414066; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=kI1jaYZTduxyUJIRjrUWGqIv9nou8jnd01X2s8YrGLY=; b=WDHbw87NlDTy4KmPqSdyGqPfbgH6ouZyMmhdDJ43WnBTFnMJWupskOA/IT2kqupeoy 2N875OsZeDQ2xtGI8/tjmuS1jGm/vH6jjT8CUDF9TyiQg7ybh8IQB/WhpHS5TU5eoTTq eG9vEX9t4d4KdnQPo8kaRLl5V9xbh/BDi7c7wGzo43olUVckctIcdEOnbi7kVWTAd9+M yqUTKQkvj7FhlW5QTN7DoUaT2uYBJGURVdEXx9lQHX0QZMYgqVqmZMVgFZHHKFCy7g89 AArocp3R9EYAy+cqfvJDixbfESUkFrMAXAnbVILPRny6bxTAcgrLsaJ9F+09/jdCXUZC QFgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762809266; x=1763414066; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kI1jaYZTduxyUJIRjrUWGqIv9nou8jnd01X2s8YrGLY=; b=fE2oOHOp55QMV3EOti0njTgwd3iSsANYxpPJwc+eHpbRdEDUNLr0igzCpYUAWJmyu/ wUJGkUx40xyfPDCBuiP5XFyL6EUcCnPFYEo8mcwouaXvIXlHK1jcYWl6Mgq/8lSx3Iyz qDUjVynp7dB37kfTao/bBg7NL6I1xUx3M1ggN6r9ZME0ms8mWnSyWdpT2oaHpAwXYXzU m3X2nHPZ4wnT/kBmSv+64xUwqoDN+y8lR4pKY5N4XzQu5GulkzALqBXlnKwiW/F2/oWd QO44upXGYnoRHjjpsyHKGeKN/IWjc9v6Dh0IIhrrUgTeTyTnZVLDTZ7rh5R54V+bF4DJ +New== X-Gm-Message-State: AOJu0YyRJ6KW7oTDMPe54RVSiYOgbbcTRfBNHvu+ItH0/QYgd2YC7zpG qD7fgd8YdlMVY7MKBCMr9qN8LTQQusDjQrXViq+VpNzX9De94hrIbh5L97wzjJrkOG0= X-Gm-Gg: ASbGncseIpyLGBONu7nhF+tzkh62c0WxVherc2k4vzrG3/BtOuIE8dxVDlseDKxVRlG +KVqK7hJnZ/Se8UYXXZH2ToWNrV1CNf+eOUBvSezNit8/0NWm2yCXGA2793z3Jgs8yKUfw4c+K5 6xeGrTgh8IZsEBOEq6zwJCEK3D3wg5oNzfp7rEKMdX96vEVs7fsqAYhkDdn89wRMRceAvZDg4Z2 dB+CyE49Bqh01sV8KfMbyQrnlOzP5fdWJC7bbwpHEoMg6D2H5WJEgp+DPoEbsxjgT1+Z4Rqo3Hb S6rCoYtXf5SGO44imOoy2ZQkYNIgqRByUtBIj/dgtYd7HWcoz1rAnEZVV5HkRh/9kDeV2J5dCos efJKYroaxckTQblw8Sb3WD4Kl/DYWjZScYTeth3VAlIAwSY6TJP1MbYRHRkQGYvANJaD3t+j6rT Y9I56vCV7FnEu/z3swcvanPvWZKslfMQ== X-Google-Smtp-Source: AGHT+IE7BCYVlZPm1RMoHnwfpXUbywlfD58ym0vhI6tUwmOGFWWCvWOvuVuW6RWqlcJ+WImPCCuEOA== X-Received: by 2002:a17:90b:2f90:b0:341:194:5e78 with SMTP id 98e67ed59e1d1-3436cbf3400mr11392529a91.21.1762809265750; Mon, 10 Nov 2025 13:14:25 -0800 (PST) Received: from localhost ([2804:14d:7e39:8083:e5cb:592:64e6:2225]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-341a69b626csm18845788a91.19.2025.11.10.13.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 13:14:25 -0800 (PST) From: Thiago Jung Bauermann To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: replace FRAME_OBSTACK_{C, Z}ALLOC macros with templated functions In-Reply-To: <20251110052145.1636979-1-simon.marchi@polymtl.ca> (simon marchi's message of "Mon, 10 Nov 2025 00:21:33 -0500") References: <20251110052145.1636979-1-simon.marchi@polymtl.ca> User-Agent: mu4e 1.12.13; emacs 30.2 Date: Mon, 10 Nov 2025 18:14:23 -0300 Message-ID: <87cy5pbnf4.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org simon.marchi@polymtl.ca writes: > From: Simon Marchi > > While reviewing a patch, I saw these macros and thought they could be > modernized a bit. Nice! Just one comment: Most calls to the new functions don't use the 'struct' keyword, e.g.: > - cache = FRAME_OBSTACK_ZALLOC (struct aarch64_prologue_cache); > + auto *cache = frame_obstack_zalloc (); while some do, e.g.: > - cache = FRAME_OBSTACK_ZALLOC (struct amd64_frame_cache); > + auto *cache = frame_obstack_zalloc (); I suggest standardising on always omitting the struct keyword. -- Thiago