Re: [PATCH] gdb: replace FRAME_OBSTACK_{C, Z}ALLOC macros with templated functions

[Simon Marchi <simon.marchi@polymtl.ca>]

On 11/10/25 4:14 PM, Thiago Jung Bauermann wrote:
> simon.marchi@polymtl.ca writes:
> 
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> While reviewing a patch, I saw these macros and thought they could be
>> modernized a bit.
> 
> Nice! Just one comment:
> 
> Most calls to the new functions don't use the 'struct' keyword, e.g.:
> 
>> -  cache = FRAME_OBSTACK_ZALLOC (struct aarch64_prologue_cache);
>> +  auto *cache = frame_obstack_zalloc<aarch64_prologue_cache> ();
> 
> while some do, e.g.:
> 
>> -  cache = FRAME_OBSTACK_ZALLOC (struct amd64_frame_cache);
>> +  auto *cache = frame_obstack_zalloc<struct amd64_frame_cache> ();
> 
> I suggest standardising on always omitting the struct keyword.

In that situations, the keyword is necessary.  I started by removing
them all, but then compilation fails if there is also a function by that
name.

Simon