Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: ams@kemisten.nu (Alfred M. Szmidt)
To: Andrew Cagney <ac131313@cygnus.com>
Cc: Richard Henderson <rth@redhat.com>,
	Richard Earnshaw <Richard.Earnshaw@arm.com>,
	gdb-patches@sources.redhat.com
Subject: Re: declare canonicalize_file_name
Date: Fri, 15 Mar 2002 00:35:00 -0000	[thread overview]
Message-ID: <87bsdq9qjl.fsf@lgh163a.kemisten.nu> (raw)
In-Reply-To: <3C9135BB.4090401@cygnus.com> (Andrew Cagney's message of "Thu, 14 Mar 2002 18:43:55 -0500")


* Andrew Cagney writes:
> The call was only just added for the hurd :-( Hmm,
> http://sources.redhat.com/ml/gdb-patches/2002-02/msg00631.html

This was added because realpath() is horribly broken, and that the Hurd
does not define any MAXPATHLEN/PATH_MAX, which in turn breaks realpath().
Which the old code depended on to be defined.

The only obscure function is realpath() that depends on the values of
MAXPATHLEN/PATH_MAX to be defined, which are not required by POSIX,
and on any system that actually provides canonicalize_file_name() it
should be used. Specially on GNU and GNU/Linux.

> Oops, ulgh! if RichardE tweeks to code (as I suggested) to simply
> prefer realpath() it will break the hurd again.  I think prefering
> realpath() is correct (only use an obscure function when forced too)
> but that logic is going to need to be scrambled a bit more :-(.

The code that has been checked in now looks OK, other then the fact that
GNU/Linux will use the obscure function realpath().

-- 
Alfred M. Szmidt


      parent reply	other threads:[~2002-03-15  8:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-14 13:28 Richard Henderson
2002-03-14 15:29 ` Andrew Cagney
2002-03-14 14:56   ` Richard Henderson
2002-03-14 15:44     ` Andrew Cagney
2002-03-14 16:07       ` rth
2002-03-14 16:27         ` Andrew Cagney
2002-03-15  0:35       ` Alfred M. Szmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bsdq9qjl.fsf@lgh163a.kemisten.nu \
    --to=ams@kemisten.nu \
    --cc=Richard.Earnshaw@arm.com \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox