From: Richard Henderson <rth@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: declare canonicalize_file_name
Date: Thu, 14 Mar 2002 13:28:00 -0000 [thread overview]
Message-ID: <20020314132845.A25190@redhat.com> (raw)
GDB uses canonicalize_file_name if it detects it in libc,
but doesn't define _GNU_SOURCE to get it declared. This
results in the compiler thinking that the function returns
an integer, which results in the pointer value being
truncated on ia64.
I figured providing a declaration was safer than forcing
_GNU_SOURCE.
Ok?
r~
* configure.in (canonicalize_file_name): Look for declaration.
* configure, config.in: Rebuild.
* utils.c (canonicalize_file_name): Provide decl if required.
Index: configure.in
===================================================================
RCS file: /cvs/src/src/gdb/configure.in,v
retrieving revision 1.83
diff -c -p -d -r1.83 configure.in
*** configure.in 2002/03/06 21:16:00 1.83
--- configure.in 2002/03/14 21:24:49
*************** BFD_NEED_DECLARATION(free)
*** 241,247 ****
BFD_NEED_DECLARATION(strerror)
BFD_NEED_DECLARATION(strdup)
BFD_NEED_DECLARATION(strstr)
!
# The following save_state_t checkery is only necessary for HPUX
# versions earlier than 10.20. When those fade from memory, this
--- 241,247 ----
BFD_NEED_DECLARATION(strerror)
BFD_NEED_DECLARATION(strdup)
BFD_NEED_DECLARATION(strstr)
! BFD_NEED_DECLARATION(canonicalize_file_name)
# The following save_state_t checkery is only necessary for HPUX
# versions earlier than 10.20. When those fade from memory, this
Index: utils.c
===================================================================
RCS file: /cvs/src/src/gdb/utils.c,v
retrieving revision 1.68
diff -c -p -d -r1.68 utils.c
*** utils.c 2002/03/01 06:19:24 1.68
--- utils.c 2002/03/14 21:24:49
*************** extern PTR realloc ();
*** 81,86 ****
--- 81,91 ----
#ifdef NEED_DECLARATION_FREE
extern void free ();
#endif
+ /* Actually, we'll never have the decl, since we don't define _GNU_SOURCE. */
+ #if defined(HAVE_CANONICALIZE_FILE_NAME) \
+ && defined(NEED_DECLARATION_CANONICALIZE_FILE_NAME)
+ extern char *canonicalize_file_name (const char *);
+ #endif
#undef XMALLOC
#define XMALLOC(TYPE) ((TYPE*) xmalloc (sizeof (TYPE)))
next reply other threads:[~2002-03-14 21:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-14 13:28 Richard Henderson [this message]
2002-03-14 15:29 ` Andrew Cagney
2002-03-14 14:56 ` Richard Henderson
2002-03-14 15:44 ` Andrew Cagney
2002-03-14 16:07 ` rth
2002-03-14 16:27 ` Andrew Cagney
2002-03-15 0:35 ` Alfred M. Szmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020314132845.A25190@redhat.com \
--to=rth@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox