From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6088 invoked by alias); 15 Mar 2002 08:35:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6002 invoked from network); 15 Mar 2002 08:35:51 -0000 Received: from unknown (HELO lgh163a.kemisten.nu) (212.32.172.173) by sources.redhat.com with SMTP; 15 Mar 2002 08:35:51 -0000 Received: from ams by lgh163a.kemisten.nu with local (Exim 3.35 #1 (Debian)) id 16lnBf-0000I9-00; Fri, 15 Mar 2002 09:35:43 +0100 To: Andrew Cagney Cc: Richard Henderson , Richard Earnshaw , gdb-patches@sources.redhat.com Subject: Re: declare canonicalize_file_name References: <20020314132845.A25190@redhat.com> <3C912539.4010009@cygnus.com> <20020314145602.B25218@redhat.com> <3C9135BB.4090401@cygnus.com> From: ams@kemisten.nu (Alfred M. Szmidt) Date: Fri, 15 Mar 2002 00:35:00 -0000 In-Reply-To: <3C9135BB.4090401@cygnus.com> (Andrew Cagney's message of "Thu, 14 Mar 2002 18:43:55 -0500") Message-ID: <87bsdq9qjl.fsf@lgh163a.kemisten.nu> User-Agent: Gnus/5.090004 (Oort Gnus v0.04) Emacs/21.2.50 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-03/txt/msg00230.txt.bz2 * Andrew Cagney writes: > The call was only just added for the hurd :-( Hmm, > http://sources.redhat.com/ml/gdb-patches/2002-02/msg00631.html This was added because realpath() is horribly broken, and that the Hurd does not define any MAXPATHLEN/PATH_MAX, which in turn breaks realpath(). Which the old code depended on to be defined. The only obscure function is realpath() that depends on the values of MAXPATHLEN/PATH_MAX to be defined, which are not required by POSIX, and on any system that actually provides canonicalize_file_name() it should be used. Specially on GNU and GNU/Linux. > Oops, ulgh! if RichardE tweeks to code (as I suggested) to simply > prefer realpath() it will break the hurd again. I think prefering > realpath() is correct (only use an obscure function when forced too) > but that logic is going to need to be scrambled a bit more :-(. The code that has been checked in now looks OK, other then the fact that GNU/Linux will use the obscure function realpath(). -- Alfred M. Szmidt