From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: RFC: close-on-exec internal file descriptors
Date: Tue, 23 Apr 2013 01:51:00 -0000 [thread overview]
Message-ID: <87bo96qpzk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87d2tmsey0.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 22 Apr 2013 10:33:27 -0600")
Tom> I rebased it and then regression tested it on x86-64 Fedora 18.
... and somehow it still regressed selftest.exp.
I don't understand how since I remember re-running the test suite and
running my comparison script.
Anyhow, here is the obvious fix.
I am checking it in.
Tom
2013-04-22 Tom Tromey <tromey@redhat.com>
* gdb.gdb/selftest.exp (do_steps_and_nexts): Check for
notice_open_fds.
Index: testsuite/gdb.gdb/selftest.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.gdb/selftest.exp,v
retrieving revision 1.33
diff -u -r1.33 selftest.exp
--- testsuite/gdb.gdb/selftest.exp 22 Jan 2013 15:47:54 -0000 1.33
+++ testsuite/gdb.gdb/selftest.exp 22 Apr 2013 20:16:37 -0000
@@ -154,6 +154,10 @@
set description "next over bfd_init"
set command "next"
}
+ -re ".*notice_open_fds ..;.*$gdb_prompt $" {
+ set description "next over notice_open_fds"
+ set command "next"
+ }
-re ".*VEC_cleanup .cmdarg_s.*$gdb_prompt $" {
set description "next over cmdarg_s VEC_cleanup"
set command "next"
next prev parent reply other threads:[~2013-04-22 20:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 17:45 Tom Tromey
2012-12-18 22:12 ` Andreas Schwab
2012-12-19 14:53 ` Tom Tromey
2013-01-03 16:17 ` Tom Tromey
2013-04-22 23:55 ` Tom Tromey
2013-04-23 1:51 ` Tom Tromey [this message]
2013-05-01 14:47 ` Joel Brobecker
2013-05-06 18:53 ` Tom Tromey
2013-05-07 6:46 ` Joel Brobecker
2013-05-10 17:00 ` Tom Tromey
2013-04-23 15:45 ` Yao Qi
2013-04-24 2:45 ` Tom Tromey
2013-04-24 20:35 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo96qpzk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox