From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100759-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21497 invoked by alias); 22 Apr 2013 20:17:54 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 21488 invoked by uid 89); 22 Apr 2013 20:17:54 -0000
X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 22 Apr 2013 20:17:53 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3MKHqAJ002042	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 22 Apr 2013 16:17:52 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3MKHpJK021451	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 22 Apr 2013 16:17:51 -0400
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: RFC: close-on-exec internal file descriptors
References: <874njjs1aa.fsf@fleche.redhat.com> <m2vcbzui0o.fsf@igel.home>	<87fw32p00e.fsf@fleche.redhat.com> <874niy6y35.fsf@fleche.redhat.com>	<87d2tmsey0.fsf@fleche.redhat.com>
Date: Tue, 23 Apr 2013 01:51:00 -0000
In-Reply-To: <87d2tmsey0.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon,	22 Apr 2013 10:33:27 -0600")
Message-ID: <87bo96qpzk.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-04/txt/msg00685.txt.bz2

Tom> I rebased it and then regression tested it on x86-64 Fedora 18.

... and somehow it still regressed selftest.exp.
I don't understand how since I remember re-running the test suite and
running my comparison script.

Anyhow, here is the obvious fix.
I am checking it in.

Tom

2013-04-22  Tom Tromey  <tromey@redhat.com>

	* gdb.gdb/selftest.exp (do_steps_and_nexts): Check for
	notice_open_fds.

Index: testsuite/gdb.gdb/selftest.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.gdb/selftest.exp,v
retrieving revision 1.33
diff -u -r1.33 selftest.exp
--- testsuite/gdb.gdb/selftest.exp	22 Jan 2013 15:47:54 -0000	1.33
+++ testsuite/gdb.gdb/selftest.exp	22 Apr 2013 20:16:37 -0000
@@ -154,6 +154,10 @@
 		set description "next over bfd_init"
 		set command "next"
 	    }
+	    -re ".*notice_open_fds ..;.*$gdb_prompt $" {
+		set description "next over notice_open_fds"
+		set command "next"
+	    }
 	    -re ".*VEC_cleanup .cmdarg_s.*$gdb_prompt $" {
 		set description "next over cmdarg_s VEC_cleanup"
 		set command "next"