From: Yao Qi <yao@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: RFC: close-on-exec internal file descriptors
Date: Tue, 23 Apr 2013 15:45:00 -0000 [thread overview]
Message-ID: <5175DF3E.10800@codesourcery.com> (raw)
In-Reply-To: <874njjs1aa.fsf@fleche.redhat.com>
Tom,
This patch causes a build regression with mingw32 cross gcc, reported
here http://sourceware.org/ml/gdb-patches/2013-04/msg00682.html and I
can reproduce it on my fedora 16:
i686-pc-mingw32-gcc -g -O2 -D__USE_MINGW_ACCESS -I. -I../../../git/gdb
-I../../../git/gdb/common -I../../../git/gdb/config
-DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H
-I../../../git/gdb/../include/opcode -I../../../git/gdb/../opcodes/..
-I../../../git/gdb/../readline/.. -I../bfd -I../../../git/gdb/../bfd
-I../../../git/gdb/../include -I../libdecnumber
-I../../../git/gdb/../libdecnumber -I./../intl
-I../../../git/gdb/gnulib/import -Ibuild-gnulib/import -Wall
-Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral
-Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch
-Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement
-Wempty-body -Wno-format -Werror -c -o filestuff.o -MT filestuff.o -MMD
-MP -MF .deps/filestuff.Tpo ../../../git/gdb/common/filestuff.c
../../../git/gdb/common/filestuff.c:31:24: fatal error: sys/socket.h: No
such file or directory
On 12/19/2012 01:44 AM, Tom Tromey wrote:
> * configure.ac: Don't check for sys/socket.h. Check for
> fdwalk, closefrom, pipe2.
Your patch doesn't mention much on why not to check sys/socket.h.
Probably we still need to check it.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-04-23 1:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 17:45 Tom Tromey
2012-12-18 22:12 ` Andreas Schwab
2012-12-19 14:53 ` Tom Tromey
2013-01-03 16:17 ` Tom Tromey
2013-04-22 23:55 ` Tom Tromey
2013-04-23 1:51 ` Tom Tromey
2013-05-01 14:47 ` Joel Brobecker
2013-05-06 18:53 ` Tom Tromey
2013-05-07 6:46 ` Joel Brobecker
2013-05-10 17:00 ` Tom Tromey
2013-04-23 15:45 ` Yao Qi [this message]
2013-04-24 2:45 ` Tom Tromey
2013-04-24 20:35 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5175DF3E.10800@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox