From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7802 invoked by alias); 23 Apr 2013 01:09:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7787 invoked by uid 89); 23 Apr 2013 01:09:20 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 23 Apr 2013 01:09:19 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UURjR-0003AA-JJ from Yao_Qi@mentor.com ; Mon, 22 Apr 2013 18:09:17 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 22 Apr 2013 18:09:17 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Mon, 22 Apr 2013 18:09:08 -0700 Message-ID: <5175DF3E.10800@codesourcery.com> Date: Tue, 23 Apr 2013 15:45:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: RFC: close-on-exec internal file descriptors References: <874njjs1aa.fsf@fleche.redhat.com> In-Reply-To: <874njjs1aa.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-04/txt/msg00696.txt.bz2 Tom, This patch causes a build regression with mingw32 cross gcc, reported here http://sourceware.org/ml/gdb-patches/2013-04/msg00682.html and I can reproduce it on my fedora 16: i686-pc-mingw32-gcc -g -O2 -D__USE_MINGW_ACCESS -I. -I../../../git/gdb -I../../../git/gdb/common -I../../../git/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../../git/gdb/../include/opcode -I../../../git/gdb/../opcodes/.. -I../../../git/gdb/../readline/.. -I../bfd -I../../../git/gdb/../bfd -I../../../git/gdb/../include -I../libdecnumber -I../../../git/gdb/../libdecnumber -I./../intl -I../../../git/gdb/gnulib/import -Ibuild-gnulib/import -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wno-format -Werror -c -o filestuff.o -MT filestuff.o -MMD -MP -MF .deps/filestuff.Tpo ../../../git/gdb/common/filestuff.c ../../../git/gdb/common/filestuff.c:31:24: fatal error: sys/socket.h: No such file or directory On 12/19/2012 01:44 AM, Tom Tromey wrote: > * configure.ac: Don't check for sys/socket.h. Check for > fdwalk, closefrom, pipe2. Your patch doesn't mention much on why not to check sys/socket.h. Probably we still need to check it. -- Yao (齐尧)