From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove a cleanup from target-descriptions.c
Date: Wed, 02 Jan 2019 23:47:00 -0000 [thread overview]
Message-ID: <87bm4ywrj2.fsf@tromey.com> (raw)
In-Reply-To: <41f2d7da837be3725bf7ca72528d2b45@polymtl.ca> (Simon Marchi's message of "Wed, 02 Jan 2019 15:40:04 -0500")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> Just wondering, is there something preventing the target_desc
Simon> structure from going to target-descriptions.h?
Nothing deep -- it's enough to just move struct property and struct
target_desc to the header.
I tried it just now. I guess it looks a little uglier, especially since
target_desc is only manipulated via accessors, thanks to common/tdesc.h.
I suppose this could all be merged more and C++-ified a bit more.
Tom
prev parent reply other threads:[~2019-01-02 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 15:52 Tom Tromey
2019-01-02 20:40 ` Simon Marchi
2019-01-02 23:47 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm4ywrj2.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox