From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove a cleanup from target-descriptions.c
Date: Wed, 02 Jan 2019 20:40:00 -0000 [thread overview]
Message-ID: <41f2d7da837be3725bf7ca72528d2b45@polymtl.ca> (raw)
In-Reply-To: <20190102155243.17250-1-tom@tromey.com>
On 2019-01-02 10:52, Tom Tromey wrote:
> This removes a cleanup from target-descriptions.c, by changing it to
> use a unique_ptr instead. Note that a deletion adapter is used, even
> though target_desc is allocated with new, to avoid moving target_desc
> to target-descriptions.h.
Just wondering, is there something preventing the target_desc structure
from going to target-descriptions.h?
The patch LGTM in any case.
Simon
next prev parent reply other threads:[~2019-01-02 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 15:52 Tom Tromey
2019-01-02 20:40 ` Simon Marchi [this message]
2019-01-02 23:47 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41f2d7da837be3725bf7ca72528d2b45@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox