From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58802 invoked by alias); 2 Jan 2019 20:40:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58747 invoked by uid 89); 2 Jan 2019 20:40:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Jan 2019 20:40:11 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x02Ke4rQ010868 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 2 Jan 2019 15:40:09 -0500 Received: by simark.ca (Postfix, from userid 112) id E867A1E7AF; Wed, 2 Jan 2019 15:40:04 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 53A6A1E05F; Wed, 2 Jan 2019 15:40:04 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 02 Jan 2019 20:40:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove a cleanup from target-descriptions.c In-Reply-To: <20190102155243.17250-1-tom@tromey.com> References: <20190102155243.17250-1-tom@tromey.com> Message-ID: <41f2d7da837be3725bf7ca72528d2b45@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00045.txt.bz2 On 2019-01-02 10:52, Tom Tromey wrote: > This removes a cleanup from target-descriptions.c, by changing it to > use a unique_ptr instead. Note that a deletion adapter is used, even > though target_desc is allocated with new, to avoid moving target_desc > to target-descriptions.h. Just wondering, is there something preventing the target_desc structure from going to target-descriptions.h? The patch LGTM in any case. Simon