From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122607 invoked by alias); 2 Jan 2019 23:47:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122570 invoked by uid 89); 2 Jan 2019 23:47:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:559 X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.231) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Jan 2019 23:47:47 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 8EC8AE1C426 for ; Wed, 2 Jan 2019 17:47:46 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id eqEkgwDvqYTGMeqEkgioSc; Wed, 02 Jan 2019 17:47:46 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RlK4E884RorXfSMpvcfaLaGbYnM9+mWnWbldlrM1CSg=; b=b9DisNkplJSOfnJ2xeWFRQGTST OWuA9AoN1SqUGgU8LyILL7XmKRP3N0R/A2KgZ1kzzF7n8lRGNmT0awCXltNit/zRCuqksC2VuHZdd plN5AgoN8VsZqRwLyIaOPKGI5; Received: from [50.236.237.38] (port=38498 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1geqEk-0015Tl-D5; Wed, 02 Jan 2019 17:47:46 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Remove a cleanup from target-descriptions.c References: <20190102155243.17250-1-tom@tromey.com> <41f2d7da837be3725bf7ca72528d2b45@polymtl.ca> Date: Wed, 02 Jan 2019 23:47:00 -0000 In-Reply-To: <41f2d7da837be3725bf7ca72528d2b45@polymtl.ca> (Simon Marchi's message of "Wed, 02 Jan 2019 15:40:04 -0500") Message-ID: <87bm4ywrj2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00052.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Just wondering, is there something preventing the target_desc Simon> structure from going to target-descriptions.h? Nothing deep -- it's enough to just move struct property and struct target_desc to the header. I tried it just now. I guess it looks a little uglier, especially since target_desc is only manipulated via accessors, thanks to common/tdesc.h. I suppose this could all be merged more and C++-ified a bit more. Tom