From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>,
Tom Tromey <tom@tromey.com>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFC] Fix comment for la_store_sym_names_in_linkage_form_p
Date: Thu, 13 Jun 2019 15:28:00 -0000 [thread overview]
Message-ID: <87blz1qzbo.fsf@tromey.com> (raw)
In-Reply-To: <7d5e8fca-cbaf-8749-1ba7-bcbad09cda63@suse.de> (Tom de Vries's message of "Thu, 13 Jun 2019 15:50:36 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> This patch fixes the comment to reflect the actual situation.
Tom> Any comments?
This is ok. Thanks for doing this.
I saw that this field is only used in a single spot in dwarf2read.c. So
it would also be fine, I think, to remove it entirely and just check the
languages there -- that's done all over dwarf2read.c already anyway.
This whole area of storing demangled names is a mess unfortunately.
It needs a big cleanup.
Tom
prev parent reply other threads:[~2019-06-13 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 13:50 Tom de Vries
2019-06-13 15:28 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blz1qzbo.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox