From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>,
Tom Tromey <tom@tromey.com>,
Joel Brobecker <brobecker@adacore.com>
Subject: [RFC] Fix comment for la_store_sym_names_in_linkage_form_p
Date: Thu, 13 Jun 2019 13:50:00 -0000 [thread overview]
Message-ID: <7d5e8fca-cbaf-8749-1ba7-bcbad09cda63@suse.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
Hi,
The comment in gdb/language.h for la_store_sym_names_in_linkage_form_p
states:
...
/* True if the symbols names should be stored in GDB's data structures
for minimal/partial/full symbols using their linkage (aka mangled)
form; false if the symbol names should be demangled first.
...
And for C++, la_store_sym_names_in_linkage_form_p is false.
However, AFAICT, while partial and full symbols are stored mangled,
minimal symbols are stored mangled.
This patch fixes the comment to reflect the actual situation.
Any comments?
Thanks,
- Tom
[-- Attachment #2: tmp.patch --]
[-- Type: text/x-patch, Size: 561 bytes --]
diff --git a/gdb/language.h b/gdb/language.h
index e7446efa07..f584a7e637 100644
--- a/gdb/language.h
+++ b/gdb/language.h
@@ -265,7 +265,7 @@ struct language_defn
const char *la_name_of_this;
/* True if the symbols names should be stored in GDB's data structures
- for minimal/partial/full symbols using their linkage (aka mangled)
+ for partial/full symbols using their linkage (aka mangled)
form; false if the symbol names should be demangled first.
Most languages implement symbol lookup by comparing the demangled
next reply other threads:[~2019-06-13 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 13:50 Tom de Vries [this message]
2019-06-13 15:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d5e8fca-cbaf-8749-1ba7-bcbad09cda63@suse.de \
--to=tdevries@suse.de \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox