From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61315 invoked by alias); 13 Jun 2019 13:50:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61307 invoked by uid 89); 13 Jun 2019 13:50:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=states X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Jun 2019 13:50:40 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C0D26AE12; Thu, 13 Jun 2019 13:50:37 +0000 (UTC) To: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey , Joel Brobecker From: Tom de Vries Subject: [RFC] Fix comment for la_store_sym_names_in_linkage_form_p Message-ID: <7d5e8fca-cbaf-8749-1ba7-bcbad09cda63@suse.de> Date: Thu, 13 Jun 2019 13:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------950C0E1F6B2F434072BD73FC" X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00247.txt.bz2 This is a multi-part message in MIME format. --------------950C0E1F6B2F434072BD73FC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 554 Hi, The comment in gdb/language.h for la_store_sym_names_in_linkage_form_p states: ... /* True if the symbols names should be stored in GDB's data structures for minimal/partial/full symbols using their linkage (aka mangled) form; false if the symbol names should be demangled first. ... And for C++, la_store_sym_names_in_linkage_form_p is false. However, AFAICT, while partial and full symbols are stored mangled, minimal symbols are stored mangled. This patch fixes the comment to reflect the actual situation. Any comments? Thanks, - Tom --------------950C0E1F6B2F434072BD73FC Content-Type: text/x-patch; name="tmp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="tmp.patch" Content-length: 561 diff --git a/gdb/language.h b/gdb/language.h index e7446efa07..f584a7e637 100644 --- a/gdb/language.h +++ b/gdb/language.h @@ -265,7 +265,7 @@ struct language_defn const char *la_name_of_this; /* True if the symbols names should be stored in GDB's data structures - for minimal/partial/full symbols using their linkage (aka mangled) + for partial/full symbols using their linkage (aka mangled) form; false if the symbol names should be demangled first. Most languages implement symbol lookup by comparing the demangled --------------950C0E1F6B2F434072BD73FC--