From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59273 invoked by alias); 13 Jun 2019 15:28:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59265 invoked by uid 89); 13 Jun 2019 15:28:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (50.116.127.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Jun 2019 15:28:45 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id A0DEFD113 for ; Thu, 13 Jun 2019 10:28:44 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id bReeh7zTa90onbReeh8FP3; Thu, 13 Jun 2019 10:28:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PQpbejzFs+SZ45+eu1z8Zk6R34kKaaqa0NDQtG3CFZk=; b=JERLrZmVZlfnF3yBtuM0g62dMz acPhdOkA+GWTXp0HLi5GFnCKsSo60NeZSHwfM4tqdmq2g9MYxSqsaULTGG4JJcmfaKCDnwicxia14 GmFvWst4P3NxvzVe7duhEXHRW; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:55826 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hbRee-003htH-BA; Thu, 13 Jun 2019 10:28:44 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey , Joel Brobecker Subject: Re: [RFC] Fix comment for la_store_sym_names_in_linkage_form_p References: <7d5e8fca-cbaf-8749-1ba7-bcbad09cda63@suse.de> Date: Thu, 13 Jun 2019 15:28:00 -0000 In-Reply-To: <7d5e8fca-cbaf-8749-1ba7-bcbad09cda63@suse.de> (Tom de Vries's message of "Thu, 13 Jun 2019 15:50:36 +0200") Message-ID: <87blz1qzbo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00248.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> This patch fixes the comment to reflect the actual situation. Tom> Any comments? This is ok. Thanks for doing this. I saw that this field is only used in a single spot in dwarf2read.c. So it would also be fine, I think, to remove it entirely and just check the languages there -- that's done all over dwarf2read.c already anyway. This whole area of storing demangled names is a mess unfortunately. It needs a big cleanup. Tom