Re: [PATCH v2 4/6] gdb: new setters and getters for __dict__, and attributes

[Tom Tromey <tom@tromey.com>]

>>>>> "Matthieu" == Matthieu Longo <matthieu.longo@arm.com> writes:

Matthieu> What about this ?

Matthieu>   value = PyDict_GetItemWithError (dict.get (), attr);
Matthieu>   if (value != nullptr)
Matthieu>     return Py_NewRef (value);

Matthieu>   /* If PyDict_GetItemWithError() returns NULL because an error occurred, it
Matthieu>      sets an exception.  Propagate it by returning NULL.  */
Matthieu>   if (PyErr_Occurred () != nullptr)
Matthieu>     return nullptr;

Matthieu>   /* If the key is not found, PyDict_GetItemWithError() returns NULL without
Matthieu>      setting an exception.  Failing to set one here would later result in:
Matthieu>        <class 'SystemError'>: error return without exception set
Matthieu>      Therefore, we must explicitly raise an AttributeError in this case.  */
Matthieu>   PyErr_Format (PyExc_AttributeError,
Matthieu> 		"'%s' object has no attribute '%s'",
Matthieu> 		Py_TYPE (self)->tp_name,
Matthieu> 		PyUnicode_AsUTF8AndSize (attr, nullptr));
Matthieu>   return nullptr;

Looks good.  If that was my only comment (I already forgot) then this is
OK.

Approved-By: Tom Tromey <tom@tromey.com>

thank you,
Tom