Re: [PATCH v2 4/6] gdb: new setters and getters for __dict__, and attributes

[Matthieu Longo <matthieu.longo@arm.com>]

On 27/01/2026 19:06, Tom Tromey wrote:
> Matthieu> -using thread_map_t
> Matthieu> -  = gdb::unordered_map<thread_info *, gdbpy_ref<thread_object>>;
> Matthieu> -
> Matthieu> -struct inferior_object
> Matthieu> -{
> Matthieu> -  PyObject_HEAD
> 
> This moved to python-internal.h, but I don't understand why that move
> is needed.

I moved the declaration to python-internal.h because of the following build issue after adding the static_assert in gdbpy_ref_policy.

   CXX    python/py-exitedevent.o
In file included from /usr/include/c++/14/bits/move.h:37,
                  from /usr/include/c++/14/bits/stl_function.h:60,
                  from /usr/include/c++/14/functional:49,
                  from ../../gdb/../gdbsupport/ptid.h:35,
                  from ../../gdb/../gdbsupport/common-defs.h:212,
                  from ./../../gdb/defs.h:26,
                  from <command-line>:
/usr/include/c++/14/type_traits: In instantiation of ‘struct std::is_base_of<_object, inferior_object>’:
../../gdb/python/py-ref.h:29:47:   required from ‘struct gdbpy_ref_policy<inferior_object>’
    29 |   static_assert(std::is_base_of<PyObject, T>::value,
       |                                               ^~~~~
../../gdb/python/py-exitedevent.c:42:18:   required from here
    42 |   if (inf_obj == NULL || evpy_add_attribute (exited_event.get (),
       |                  ^~~~
/usr/include/c++/14/type_traits:1493:30: error: invalid use of incomplete type ‘struct inferior_object’
  1493 |     : public __bool_constant<__is_base_of(_Base, _Derived)>
       |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../gdb/python/py-events.h:24,
                  from ../../gdb/python/py-event.h:23,
                  from ../../gdb/python/py-exitedevent.c:20:
../../gdb/python/python-internal.h:405:8: note: forward declaration of ‘struct inferior_object’
   405 | struct inferior_object;
       |        ^~~~~~~~~~~~~~~
In file included from ../../gdb/python/python-internal.h:61:
../../gdb/python/py-ref.h: In instantiation of ‘struct gdbpy_ref_policy<inferior_object>’:
../../gdb/python/py-exitedevent.c:42:18:   required from here
    42 |   if (inf_obj == NULL || evpy_add_attribute (exited_event.get (),
       |                  ^~~~
../../gdb/python/py-ref.h:29:47: error: ‘value’ is not a member of ‘std::is_base_of<_object, inferior_object>’
    29 |   static_assert(std::is_base_of<PyObject, T>::value,
       |                                               ^~~~~