From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id e3VMKiVze2nYvBsAWB0awg (envelope-from ) for ; Thu, 29 Jan 2026 09:48:05 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jnJDFSdx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9C49D1E08D; Thu, 29 Jan 2026 09:48:05 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B8EB21E08D for ; Thu, 29 Jan 2026 09:48:04 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 44E7A4BB3BC1 for ; Thu, 29 Jan 2026 14:48:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 44E7A4BB3BC1 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jnJDFSdx Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id A8F9B4BAE7DF for ; Thu, 29 Jan 2026 14:45:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8F9B4BAE7DF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A8F9B4BAE7DF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769697917; cv=none; b=ChqI1TJVa47+uWIPx05y3zVErqr9CnzCB8jKxUV70tVhZbiLkkf0yikXgi3ok3MelYwR8USiEMzjQraRUxOjbuDofNw9taRqJy1SJ9Z+5ggeduGS6WjSkvlWp7kbn+CVX692QfzC7L+jPD0OYHWmdID3Hm2opF08Ww3TXAo9CXw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769697917; c=relaxed/simple; bh=pDEz6sE7TC5dybQo0AEIfgr4YwSfOJIyBkSIVXnDgwA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BJLH9qaG0TR/icz8Y4q5RafovG7BhHLBmWBdvIPkJnCFfXZFtgsXSp6PBrcjHfa09X16GxSF8Xf1IbPLEr8lc3GNHQ9OC5lJ0653onOaH10v0P3duAow9YbbbCwx1AsyJmeE4dNAPUjhjau2bvL+/KO8+lob+eTIfjQB5LEH/Xc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A8F9B4BAE7DF Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id lNsivvxWXipkClTGlvKcpL; Thu, 29 Jan 2026 14:45:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id lTGkv3erBOs9RlTGlvXO6O; Thu, 29 Jan 2026 14:45:15 +0000 X-Authority-Analysis: v=2.4 cv=HPPDFptv c=1 sm=1 tr=0 ts=697b727b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=zstS-IiYAAAA:8 a=GYi0_vRIB5HtQV8oJzEA:9 a=a-qgeE7W1pNrGK8U0ZQC:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=E7TdC6TDb/uNF7ZvX/A8jGZyPmH3rdnJRvsrOK6wruw=; b=jnJDFSdxbXJqrQIF/02boNJ/js A+cTV5jMh8vQyd63SUmYXLOIAZZz3fhSHsFXoII3ESvDgqzaAL3EHriBRFy5q4SBdtA99c+NgOKxx JjovXC+BsjksJCfJm9C4mZpH1; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:56402 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vlTGk-00000001rU3-1uwX; Thu, 29 Jan 2026 07:45:14 -0700 From: Tom Tromey To: Matthieu Longo Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 4/6] gdb: new setters and getters for __dict__, and attributes In-Reply-To: <2fa36bd8-5d84-4432-a6c7-77837f5dc850@arm.com> (Matthieu Longo's message of "Thu, 29 Jan 2026 10:42:52 +0000") References: <20260128120239.1959325-1-matthieu.longo@arm.com> <87qzr98vo4.fsf@tromey.com> <2fa36bd8-5d84-4432-a6c7-77837f5dc850@arm.com> X-Attribution: Tom Date: Thu, 29 Jan 2026 07:45:11 -0700 Message-ID: <87bjic1nrc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1vlTGk-00000001rU3-1uwX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net (prentzel) [97.122.114.32]:56402 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLXWyunFgg1WMVIFFos+O08uIp6TxfcWo7uUv7/70kma5H/EII0hhdM1Dt9OSpi4aciFT1vAkkTxTqhzr43+0oxkj3qWzzg1JmeQRw5D7Lc1DxOik1DU JAoWoegKGMuJpVU74Ycxx5C0qoMiqpFnlCGyZL2/EYf92853Dac30VYkgHANxfQkz1mWeP0pzjtONMAtH43yem/JZiS5evv1vI0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Matthieu" == Matthieu Longo writes: Matthieu> What about this ? Matthieu> value = PyDict_GetItemWithError (dict.get (), attr); Matthieu> if (value != nullptr) Matthieu> return Py_NewRef (value); Matthieu> /* If PyDict_GetItemWithError() returns NULL because an error occurred, it Matthieu> sets an exception. Propagate it by returning NULL. */ Matthieu> if (PyErr_Occurred () != nullptr) Matthieu> return nullptr; Matthieu> /* If the key is not found, PyDict_GetItemWithError() returns NULL without Matthieu> setting an exception. Failing to set one here would later result in: Matthieu> : error return without exception set Matthieu> Therefore, we must explicitly raise an AttributeError in this case. */ Matthieu> PyErr_Format (PyExc_AttributeError, Matthieu> "'%s' object has no attribute '%s'", Matthieu> Py_TYPE (self)->tp_name, Matthieu> PyUnicode_AsUTF8AndSize (attr, nullptr)); Matthieu> return nullptr; Looks good. If that was my only comment (I already forgot) then this is OK. Approved-By: Tom Tromey thank you, Tom