From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: really free pending_blocks, v2
Date: Thu, 29 Nov 2012 16:18:00 -0000 [thread overview]
Message-ID: <87a9u07588.fsf@fleche.redhat.com> (raw)
In-Reply-To: <50B788C4.60707@redhat.com> (Pedro Alves's message of "Thu, 29 Nov 2012 16:09:40 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> +static struct pending_block *pending_blocks;
Pedro> Do we take care of always clearing this before starting a new symtab?
If we don't, then I think it is an existing bug, not affected by this
patch.
But, we do take care. The various symbol readers install
really_free_pendings as a cleanup.
buildsym in general is a mess, mostly because it works using a lot of
globals. It's never been actively bad enough to fix, though -- it came
close with the dwz work, but still managed to dodge a big cleanup.
Tom
next prev parent reply other threads:[~2012-11-29 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 15:25 Tom Tromey
2012-11-29 16:09 ` Pedro Alves
2012-11-29 16:18 ` Tom Tromey [this message]
2012-12-10 17:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9u07588.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox