From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: really free pending_blocks, v2
Date: Thu, 29 Nov 2012 16:09:00 -0000 [thread overview]
Message-ID: <50B788C4.60707@redhat.com> (raw)
In-Reply-To: <87mwy077ny.fsf@fleche.redhat.com>
On 11/29/2012 03:25 PM, Tom Tromey wrote:
>
> +/* An obstack used for allocating pending blocks. */
> +
> +static struct obstack pending_block_obstack;
> +
> +/* List of blocks already made (lexical contexts already closed).
> + This is used at the end to make the blockvector. */
> +
> +struct pending_block
> + {
> + struct pending_block *next;
> + struct block *block;
> + };
> +
> +/* Pointer to the head of a linked list of symbol blocks which have
> + already been finalized (lexical contexts already closed) and which
> + are just waiting to be built into a blockvector when finalizing the
> + associated symtab. */
> +
> +static struct pending_block *pending_blocks;
Do we take care of always clearing this before starting a new symtab?
What I'm worried about is throwing an error during debug info
reading leading to a stale pending_blocks list that gets later added
to by mistake, the next time we start another read.
--
Pedro Alves
next prev parent reply other threads:[~2012-11-29 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 15:25 Tom Tromey
2012-11-29 16:09 ` Pedro Alves [this message]
2012-11-29 16:18 ` Tom Tromey
2012-12-10 17:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B788C4.60707@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox