From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17977 invoked by alias); 29 Nov 2012 16:18:26 -0000 Received: (qmail 17947 invoked by uid 22791); 29 Nov 2012 16:18:22 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_DW X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Nov 2012 16:18:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qATGIGqd030034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Nov 2012 11:18:16 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qATGIFs3029026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 29 Nov 2012 11:18:16 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: RFC: really free pending_blocks, v2 References: <87mwy077ny.fsf@fleche.redhat.com> <50B788C4.60707@redhat.com> Date: Thu, 29 Nov 2012 16:18:00 -0000 In-Reply-To: <50B788C4.60707@redhat.com> (Pedro Alves's message of "Thu, 29 Nov 2012 16:09:40 +0000") Message-ID: <87a9u07588.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00875.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> +static struct pending_block *pending_blocks; Pedro> Do we take care of always clearing this before starting a new symtab? If we don't, then I think it is an existing bug, not affected by this patch. But, we do take care. The various symbol readers install really_free_pendings as a cleanup. buildsym in general is a mess, mostly because it works using a lot of globals. It's never been actively bad enough to fix, though -- it came close with the dwz work, but still managed to dodge a big cleanup. Tom